From: Hector Oron <hector.oron@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] libcc1: dynamic load versioned library
Date: Tue, 24 Mar 2015 17:06:00 -0000 [thread overview]
Message-ID: <CAODfWeHbrK0mvAFoVTGn=Nv6otOozx7C8h_461xB-+KducVtfg@mail.gmail.com> (raw)
In-Reply-To: <201503241633.t2OGX6aO002810@glazunov.sibelius.xs4all.nl>
Hello,
2015-03-24 17:33 GMT+01:00 Mark Kettenis <mark.kettenis@xs4all.nl>:
>> From: Hector Oron <hector.oron@gmail.com>
>>
>> Hello,
>>
>> I believe libcc1 is versioned library therefore, it should dlopen on
>> libcc1.so.0 instead libcc1.so.
>> The patch should be applied to master and 7.9 branch.
>
> And what happens if the major version of the library is bumped?
Does that mean that there is some ABI break which might imply or not
newer changes on GDB side?
>> Héctor Orón Martínez
>>
>> * include/gcc-c-interface.h (gcc_c_context): load libcc1 versioned library
>>
>> --- gdb-7.9.orig/include/gcc-c-interface.h
>> +++ gdb-7.9/include/gcc-c-interface.h
>> @@ -197,7 +197,7 @@ struct gcc_c_context
>> /* The name of the .so that the compiler builds. We dlopen this
>> later. */
>>
>> -#define GCC_C_FE_LIBCC libcc1.so
>> +#define GCC_C_FE_LIBCC libcc1.so.0
>>
>> /* The compiler exports a single initialization function. This macro
>> holds its name as a symbol. */
>>
>> Regards,
>> --
>> Héctor Orón -.. . -... .. .- -. -.. . ...- . .-.. --- .--. . .-.
>>
>>
--
Héctor Orón -.. . -... .. .- -. -.. . ...- . .-.. --- .--. . .-.
next prev parent reply other threads:[~2015-03-24 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 16:07 Hector Oron
2015-03-24 16:33 ` Mark Kettenis
2015-03-24 17:06 ` Hector Oron [this message]
2015-03-24 19:46 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAODfWeHbrK0mvAFoVTGn=Nv6otOozx7C8h_461xB-+KducVtfg@mail.gmail.com' \
--to=hector.oron@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox