From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66300 invoked by alias); 24 Mar 2015 17:06:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66290 invoked by uid 89); 24 Mar 2015 17:06:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-lb0-f182.google.com Received: from mail-lb0-f182.google.com (HELO mail-lb0-f182.google.com) (209.85.217.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 24 Mar 2015 17:06:16 +0000 Received: by lbcgn8 with SMTP id gn8so145516346lbc.2 for ; Tue, 24 Mar 2015 10:06:13 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.42.171 with SMTP id p11mr4464284lal.75.1427216773255; Tue, 24 Mar 2015 10:06:13 -0700 (PDT) Received: by 10.112.154.4 with HTTP; Tue, 24 Mar 2015 10:06:13 -0700 (PDT) In-Reply-To: <201503241633.t2OGX6aO002810@glazunov.sibelius.xs4all.nl> References: <201503241633.t2OGX6aO002810@glazunov.sibelius.xs4all.nl> Date: Tue, 24 Mar 2015 17:06:00 -0000 Message-ID: Subject: Re: [patch] libcc1: dynamic load versioned library From: Hector Oron To: Mark Kettenis Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-03/txt/msg00800.txt.bz2 Hello, 2015-03-24 17:33 GMT+01:00 Mark Kettenis : >> From: Hector Oron >> >> Hello, >> >> I believe libcc1 is versioned library therefore, it should dlopen on >> libcc1.so.0 instead libcc1.so. >> The patch should be applied to master and 7.9 branch. > > And what happens if the major version of the library is bumped? Does that mean that there is some ABI break which might imply or not newer changes on GDB side? >> H=C3=A9ctor Or=C3=B3n Mart=C3=ADnez >> >> * include/gcc-c-interface.h (gcc_c_context): load libcc1 versioned l= ibrary >> >> --- gdb-7.9.orig/include/gcc-c-interface.h >> +++ gdb-7.9/include/gcc-c-interface.h >> @@ -197,7 +197,7 @@ struct gcc_c_context >> /* The name of the .so that the compiler builds. We dlopen this >> later. */ >> >> -#define GCC_C_FE_LIBCC libcc1.so >> +#define GCC_C_FE_LIBCC libcc1.so.0 >> >> /* The compiler exports a single initialization function. This macro >> holds its name as a symbol. */ >> >> Regards, >> -- >> H=C3=A9ctor Or=C3=B3n -.. . -... .. .- -. -.. . ...- . .-.. --- .--.= . .-. >> >> --=20 H=C3=A9ctor Or=C3=B3n -.. . -... .. .- -. -.. . ...- . .-.. --- .--. . = .-.