From: Pavel Chupin <pavel.v.chupin@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] fix sim build when configured with --enable-plugins
Date: Thu, 15 Nov 2012 14:32:00 -0000 [thread overview]
Message-ID: <CANwJu1_gKMxvsQtdPDKLQBUfY-UT6t=YcgkUDyUOjumkifvPtg@mail.gmail.com> (raw)
Hi,
Patch below fix sim builds for some targets when bfd build is
configured with --enable-plugins. In this case libbfd.a (plugin.o) has
dependencies on libdl so it should be included into link commands,
similar as zlib.
Is it OK for trunk?
Patch:
diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4
index fe0a5b7..1d2fd1c 100644
--- a/sim/common/acinclude.m4
+++ b/sim/common/acinclude.m4
@@ -21,6 +21,7 @@
# Include global overrides and fixes for Autoconf.
m4_include(../../config/override.m4)
sinclude([../../config/zlib.m4])
+sinclude([../../config/plugins.m4])
sinclude([../../config/depstand.m4])
AC_DEFUN([SIM_AC_COMMON],
@@ -90,6 +91,12 @@ AC_CHECK_LIB(nsl, gethostbyname)
# using the same condition.
AM_ZLIB
+# BFD uses libdl when when plugins enabled.
+AC_PLUGINS
+if test "x$plugins" = "xyes"; then
+ LIBS+=" -ldl"
+fi
+
. ${srcdir}/../../bfd/configure.host
dnl Standard (and optional) simulator options.
sim/ChangeLog entry:
2012-11-09 Pavel Chupin <pavel.v.chupin@intel.com>
Fix sim build when bfd is configured with --enable-plugins
* arm/configure: Regenerate.
* avr/configure: Regenerate.
* bfin/configure: Regenerate.
* common/acinclude.m4: Add libdl into LIBS.
* common/configure: Regenerate.
* cr16/configure: Regenerate.
* cris/configure: Regenerate.
* d10v/configure: Regenerate.
* erc32/configure: Regenerate.
* frv/configure: Regenerate.
* h8300/configure: Regenerate.
* igen/configure: Regenerate.
* iq2000/configure: Regenerate.
* lm32/configure: Regenerate.
* m32c/configure: Regenerate.
* m32r/configure: Regenerate.
* m68hc11/configure: Regenerate.
* mcore/configure: Regenerate.
* microblaze/configure: Regenerate.
* mips/configure: Regenerate.
* mn10300/configure: Regenerate.
* moxie/configure: Regenerate.
* ppc/configure: Regenerate.
* rl78/configure: Regenerate.
* rx/configure: Regenerate.
* sh/configure: Regenerate.
* sh64/configure: Regenerate.
* testsuite/configure: Regenerate.
* v850/configure: Regenerate.
Can be reproduced on trunk with (for example):
configure --enable-plugins --target arm-linux-androideabi
make
Error:
gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1
-DDEFAULT_INLINE=0 -DMODET -DNEED_UI_LOOP_HOOK
-DSIM_TARGET_SWITCHES -I. -I../../../sim/arm -I../common
-I../../../sim/arm/../common -I../../include
-I../../../sim/arm/../../include -I../../bfd
-I../../../sim/arm/../../bfd -I../../opcodes
-I../../../sim/arm/../../opcodes -g -O2 -static-libstdc++
-static-libgcc -o run \
run.o libsim.a ../../bfd/libbfd.a ../../opcodes/libopcodes.a
../../libiberty/libiberty.a -lz -lnsl
../../bfd/libbfd.a(plugin.o): In function `try_load_plugin':
/tmp/gdb/BUILD/bfd/../../bfd/plugin.c:170: undefined reference to `dlopen'
/tmp/gdb/BUILD/bfd/../../bfd/plugin.c:177: undefined reference to `dlsym'
/tmp/gdb/BUILD/bfd/../../bfd/plugin.c:173: undefined reference to `dlerror'
--
Pavel Chupin
Intel Corporation
next reply other threads:[~2012-11-15 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:32 Pavel Chupin [this message]
2012-11-15 14:36 ` H.J. Lu
2012-11-16 9:14 ` Pavel Chupin
2012-11-17 8:09 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANwJu1_gKMxvsQtdPDKLQBUfY-UT6t=YcgkUDyUOjumkifvPtg@mail.gmail.com' \
--to=pavel.v.chupin@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox