From: "H.J. Lu" <hjl.tools@gmail.com>
To: Pavel Chupin <pavel.v.chupin@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix sim build when configured with --enable-plugins
Date: Thu, 15 Nov 2012 14:36:00 -0000 [thread overview]
Message-ID: <CAMe9rOqKivJbfDBZCQ=uoO5pj+rQzDWL3WXLgw6fBw6HrO3_Ug@mail.gmail.com> (raw)
In-Reply-To: <CANwJu1_gKMxvsQtdPDKLQBUfY-UT6t=YcgkUDyUOjumkifvPtg@mail.gmail.com>
On Thu, Nov 15, 2012 at 6:31 AM, Pavel Chupin <pavel.v.chupin@gmail.com> wrote:
> Hi,
> Patch below fix sim builds for some targets when bfd build is
> configured with --enable-plugins. In this case libbfd.a (plugin.o) has
> dependencies on libdl so it should be included into link commands,
> similar as zlib.
> Is it OK for trunk?
>
> Patch:
>
> diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4
> index fe0a5b7..1d2fd1c 100644
> --- a/sim/common/acinclude.m4
> +++ b/sim/common/acinclude.m4
> @@ -21,6 +21,7 @@
> # Include global overrides and fixes for Autoconf.
> m4_include(../../config/override.m4)
> sinclude([../../config/zlib.m4])
> +sinclude([../../config/plugins.m4])
> sinclude([../../config/depstand.m4])
>
> AC_DEFUN([SIM_AC_COMMON],
> @@ -90,6 +91,12 @@ AC_CHECK_LIB(nsl, gethostbyname)
> # using the same condition.
> AM_ZLIB
>
> +# BFD uses libdl when when plugins enabled.
> +AC_PLUGINS
> +if test "x$plugins" = "xyes"; then
> + LIBS+=" -ldl"
> +fi
> +
This is wrong. Please do it like:
http://sourceware.org/git/?p=binutils.git;a=patch;h=f780e457f046c09d336e4dab0ffbcfbec70bfbee
--
H.J.
next prev parent reply other threads:[~2012-11-15 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:32 Pavel Chupin
2012-11-15 14:36 ` H.J. Lu [this message]
2012-11-16 9:14 ` Pavel Chupin
2012-11-17 8:09 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqKivJbfDBZCQ=uoO5pj+rQzDWL3WXLgw6fBw6HrO3_Ug@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pavel.v.chupin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox