From: Will Newton <will.newton@linaro.org>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] testsuite/gdb.base: Make skip test not rely on undefined behaviour.
Date: Wed, 12 Jun 2013 09:54:00 -0000 [thread overview]
Message-ID: <CANu=DmgzJS9sw_U3BH3k5GqBu82e49m-eJT9j0L2O6DJs2+BAQ@mail.gmail.com> (raw)
In-Reply-To: <CA+=Sn1kYLbmMeqhNZ_SsUpJvAB9ftHWpYO-BHwBWYOL0V1ua7Q@mail.gmail.com>
On 12 June 2013 00:00, Andrew Pinski <pinskia@gmail.com> wrote:
> On Fri, Jun 7, 2013 at 11:41 AM, Will Newton <will.newton@linaro.org> wrote:
>>
>> The skip test currently relies on the order of evaluation of
>> arguments which is not defined. Use an arithmetic expression
>> where order is defined instead.
>
>
> No the order is not defined there either. The left side or the right
> side of the addition can be evaluated first as there is no sequence
> point. Maybe it is better to do:
> baz((foo(), bar()));
>
> The order with that is defined as the comma operator is a sequence point.
Thanks, I was getting associativity mixed up with evaluation order.
I'll respin the patch with that change.
--
Will Newton
Toolchain Working Group, Linaro
prev parent reply other threads:[~2013-06-12 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 18:58 Will Newton
2013-06-11 23:02 ` Andrew Pinski
2013-06-12 9:54 ` Will Newton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANu=DmgzJS9sw_U3BH3k5GqBu82e49m-eJT9j0L2O6DJs2+BAQ@mail.gmail.com' \
--to=will.newton@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox