From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24861 invoked by alias); 12 Jun 2013 09:51:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24850 invoked by uid 89); 12 Jun 2013 09:51:05 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ie0-f178.google.com (HELO mail-ie0-f178.google.com) (209.85.223.178) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 09:50:55 +0000 Received: by mail-ie0-f178.google.com with SMTP id u16so240932iet.9 for ; Wed, 12 Jun 2013 02:50:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=rCOyODTIGlJaKx01YQ8VCwRgta0Knqd2p4pyj9YjMBY=; b=Lf3SAwNNWqT3Cx4j/lFafzBUbllUzqUegoksIQFbAHVcxmkDPaxmmaTH11N3flC4QL 95ATE/LH3LgUzvNfkJ8wrSTbG9QQcp7DPKdwU1d/mtbCZIZqTLRC8drHp3MWkVIcmAYE u0e02J9iGyVoSWcfd8Gs25/y1GxLDlbNau7tZXD4dSw5VcY08ujTBoIJ9KeWpRjiq0Lc SH8iPz0tG/W49ifZTLgtj6hvJrWiDlwVARRRcG577xy5SAvYEv0ikzAYUBj4MjIlVFle czwWVIHm96NjpS8g9w0Mcog3MQ2VR9LWfp0OKGuuldSj8IU9d2iQdnQBaMqorHaQaytC Fecg== MIME-Version: 1.0 X-Received: by 10.50.50.164 with SMTP id d4mr2955841igo.69.1371030654270; Wed, 12 Jun 2013 02:50:54 -0700 (PDT) Received: by 10.64.8.111 with HTTP; Wed, 12 Jun 2013 02:50:54 -0700 (PDT) In-Reply-To: References: <51B22951.1000601@linaro.org> Date: Wed, 12 Jun 2013 09:54:00 -0000 Message-ID: Subject: Re: [PATCH] testsuite/gdb.base: Make skip test not rely on undefined behaviour. From: Will Newton To: Andrew Pinski Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlB/f70isLrLvxjXW1z+5fOdqH4kVqmsqRLoVIOLJDcClpzeYm/i1t/EXYRc/H8zNxJscxw X-SW-Source: 2013-06/txt/msg00269.txt.bz2 On 12 June 2013 00:00, Andrew Pinski wrote: > On Fri, Jun 7, 2013 at 11:41 AM, Will Newton wrote: >> >> The skip test currently relies on the order of evaluation of >> arguments which is not defined. Use an arithmetic expression >> where order is defined instead. > > > No the order is not defined there either. The left side or the right > side of the addition can be evaluated first as there is no sequence > point. Maybe it is better to do: > baz((foo(), bar())); > > The order with that is defined as the comma operator is a sequence point. Thanks, I was getting associativity mixed up with evaluation order. I'll respin the patch with that change. -- Will Newton Toolchain Working Group, Linaro