From: Hui Zhu <teawater@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/tracepoint] Make GDB can work with some old GDB server
Date: Wed, 06 Jul 2011 09:33:00 -0000 [thread overview]
Message-ID: <CANFwon3rxuyhTyn1ngvJpiNHBgdQzizXY5ShCS_r3zBCcA3CLg@mail.gmail.com> (raw)
In-Reply-To: <m3aacstw4x.fsf@fleche.redhat.com>
Hi Tom,
Thanks for your review.
Fixed and checked in.
Do you think this patch is OK for 7.3 branch?
Best,
Hui
On Wed, Jul 6, 2011 at 02:33, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2011-06-24 Hui Zhu <teawater@gmail.com>
>>> * remote.c (remote_start_remote): Add TRY_CATCH for
>>> remote_get_trace_status.
>>> * tracepoint.c (disconnect_tracing): Ditto.
>
> It seems reasonable enough to me, but I would prefer that somebody more
> knowledgeable about remote.c review this.
>
>>> + warning(_("%s"), ex.message);
>
> Space before the first open paren.
>
>>> + warning(_("%s"), ex.message);
>
> Likewise.
>
> Tom
>
next prev parent reply other threads:[~2011-07-06 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 8:47 Hui Zhu
2011-07-04 6:04 ` Hui Zhu
2011-07-05 18:35 ` Tom Tromey
2011-07-06 9:33 ` Hui Zhu [this message]
2011-07-06 14:40 ` Tom Tromey
2011-07-07 8:41 ` Hui Zhu
2011-07-07 11:35 ` Jan Kratochvil
2011-07-07 13:46 ` Hui Zhu
2011-07-13 19:19 ` Jan Kratochvil
2011-07-14 6:27 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANFwon3rxuyhTyn1ngvJpiNHBgdQzizXY5ShCS_r3zBCcA3CLg@mail.gmail.com \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox