From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31765 invoked by alias); 6 Jul 2011 02:46:01 -0000 Received: (qmail 31755 invoked by uid 22791); 6 Jul 2011 02:46:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f54.google.com (HELO mail-fx0-f54.google.com) (209.85.161.54) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 02:45:46 +0000 Received: by fxe4 with SMTP id 4so6428754fxe.13 for ; Tue, 05 Jul 2011 19:45:45 -0700 (PDT) Received: by 10.223.145.78 with SMTP id c14mr12162369fav.75.1309920345075; Tue, 05 Jul 2011 19:45:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.112.3 with HTTP; Tue, 5 Jul 2011 19:45:05 -0700 (PDT) In-Reply-To: References: From: Hui Zhu Date: Wed, 06 Jul 2011 09:33:00 -0000 Message-ID: Subject: Re: [RFA/tracepoint] Make GDB can work with some old GDB server To: Tom Tromey Cc: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00183.txt.bz2 Hi Tom, Thanks for your review. Fixed and checked in. Do you think this patch is OK for 7.3 branch? Best, Hui On Wed, Jul 6, 2011 at 02:33, Tom Tromey wrote: >>>>>> ">" =3D=3D Hui Zhu writes: > >>> 2011-06-24 =A0Hui Zhu =A0 >>> =A0 =A0 =A0* remote.c (remote_start_remote): Add TRY_CATCH for >>> =A0 =A0 =A0remote_get_trace_status. >>> =A0 =A0 =A0* tracepoint.c (disconnect_tracing): Ditto. > > It seems reasonable enough to me, but I would prefer that somebody more > knowledgeable about remote.c review this. > >>> + =A0 =A0 =A0warning(_("%s"), ex.message); > > Space before the first open paren. > >>> + =A0 =A0 =A0warning(_("%s"), ex.message); > > Likewise. > > Tom >