Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin
Date: Mon, 09 Sep 2013 14:27:00 -0000	[thread overview]
Message-ID: <CANFwon3Xny3nWLpUumJu2cuwy7vLXkGa+cEVSV1+AHmAZ66WRg@mail.gmail.com> (raw)
In-Reply-To: <522DD104.6090808@codesourcery.com>

On Mon, Sep 9, 2013 at 9:45 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 09/09/2013 04:40 PM, Hui Zhu wrote:
>>
>> -    send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> +    if { "${plus_var}" == "" } {
>> +       send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> +    } else {
>> +       send_gdb "shell grep -E \" ${plus_var} .* ${var}(\[ \t\]+.*)?\$\"
>> ${msymfile}\n"
>> +    }
>
>
> Why don't do this unconditionally?
>
> send_gdb "shell grep -E \" T .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"


Because other test use this function too.

Thanks,
Hui

>
> --
> Yao (齐尧)


  reply	other threads:[~2013-09-09 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09  8:41 Hui Zhu
2013-09-09 13:46 ` Yao Qi
2013-09-09 14:27   ` Hui Zhu [this message]
2013-09-12  6:31     ` Hui Zhu
2013-09-12  6:50       ` Yao Qi
2013-09-12  7:28         ` Hui Zhu
2013-10-07  9:28           ` Hui Zhu
2013-11-24 12:14           ` Fwd: " Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon3Xny3nWLpUumJu2cuwy7vLXkGa+cEVSV1+AHmAZ66WRg@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox