From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105146-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19823 invoked by alias); 9 Sep 2013 14:27:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19811 invoked by uid 89); 9 Sep 2013 14:27:18 -0000
Received: from mail-oa0-f50.google.com (HELO mail-oa0-f50.google.com) (209.85.219.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 09 Sep 2013 14:27:18 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GARBLED_BODY,KHOP_THREADED,NO_RELAYS autolearn=no version=3.3.2
X-HELO: mail-oa0-f50.google.com
Received: by mail-oa0-f50.google.com with SMTP id i4so6630528oah.9        for <gdb-patches@sourceware.org>; Mon, 09 Sep 2013 07:27:16 -0700 (PDT)
X-Received: by 10.60.134.230 with SMTP id pn6mr834552oeb.52.1378736836197; Mon, 09 Sep 2013 07:27:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.7.97 with HTTP; Mon, 9 Sep 2013 07:26:36 -0700 (PDT)
In-Reply-To: <522DD104.6090808@codesourcery.com>
References: <CANFwon0RVVQKLg2Ffm+TWQSKrJRTTtZ-573iJQ_T_HWMrm1hGQ@mail.gmail.com> <522DD104.6090808@codesourcery.com>
From: Hui Zhu <teawater@gmail.com>
Date: Mon, 09 Sep 2013 14:27:00 -0000
Message-ID: <CANFwon3Xny3nWLpUumJu2cuwy7vLXkGa+cEVSV1+AHmAZ66WRg@mail.gmail.com>
Subject: Re: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00291.txt.bz2

On Mon, Sep 9, 2013 at 9:45 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 09/09/2013 04:40 PM, Hui Zhu wrote:
>>
>> -    send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> +    if { "${plus_var}" =3D=3D "" } {
>> +       send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> +    } else {
>> +       send_gdb "shell grep -E \" ${plus_var} .* ${var}(\[ \t\]+.*)?\$\"
>> ${msymfile}\n"
>> +    }
>
>
> Why don't do this unconditionally?
>
> send_gdb "shell grep -E \" T .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"


Because other test use this function too.

Thanks,
Hui

>
> --
> Yao (=E9=BD=90=E5=B0=A7)