Re: [PATCH] add -s option to make -break-insert support dprintf

[Hui Zhu <teawater@gmail.com>]

Ping http://sourceware.org/ml/gdb-patches/2013-05/msg00460.html

Thanks,
Hui

On Tue, May 14, 2013 at 12:56 PM, Hui Zhu <teawater@gmail.com> wrote:
> On Mon, May 13, 2013 at 11:55 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> From: Hui Zhu <teawater@gmail.com>
>>> Date: Mon, 13 May 2013 11:38:40 +0800
>>> Cc: tromey@redhat.com, palves@redhat.com, hui_zhu@mentor.com,
>>>       gdb-patches@sourceware.org, marc.khouzam@ericsson.com
>>>
>>> >> +If @var{location} cannot be parsed (for example if it
>>> >                                                   ^
>>> > A comma is missing.
>>>
>>> The comma is after the right parenthesis: refers to unknown files or functions),
>>> Do I need change this part to following format?
>>> If @var{location} cannot be parsed, (for example if it
>>> refers to unknown files or functions) create a pending
>>
>> No, I meant the comma after "for example", inside the parentheses.
>
> Fixed.
>
> Post a new version for it.
>
> Thanks,
> Hui
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * breakpoint.c (dprintf_breakpoint_ops): Remove its static.
>         * breakpoint.h (dprintf_breakpoint_ops): Add extern.
>         * mi/mi-cmd-break.c (ctype.h): New include.
>         (gdb_obstack.h): New include.
>         (mi_argv_to_format, mi_cmd_break_insert_1): New.
>         (mi_cmd_break_insert): Call mi_cmd_break_insert_1.
>         (mi_cmd_dprintf_insert): New.
>         * mi/mi-cmds.c (mi_cmds): Add "dprintf-insert".
>         * mi/mi-cmds.h (mi_cmd_dprintf_insert): New extern.
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * gdb.texinfo (GDB/MI Breakpoint Commands): Describe the
>         "-dprintf-insert" command.
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * gdb.mi/Makefile.in (PROGS): Add "mi-dprintf".
>         * gdb.mi/mi-dprintf.exp, gdb.mi/mi-dprintf.c: New.