From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101710-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24588 invoked by alias); 20 May 2013 07:31:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24576 invoked by uid 89); 20 May 2013 07:31:27 -0000
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 07:31:26 +0000
Received: by mail-ob0-f169.google.com with SMTP id vb8so6807538obc.0        for <gdb-patches@sourceware.org>; Mon, 20 May 2013 00:31:25 -0700 (PDT)
X-Received: by 10.60.23.9 with SMTP id i9mr19277155oef.109.1369035085172; Mon, 20 May 2013 00:31:25 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.11.135 with HTTP; Mon, 20 May 2013 00:30:44 -0700 (PDT)
In-Reply-To: <CANFwon0fMc6efTtEVn_WLQ+8EaCzQ6f2AJH22jPg1RHyhnM2eg@mail.gmail.com>
References: <515451EA.1000200@mentor.com> <83y5d7wpvq.fsf@gnu.org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q@mail.gmail.com> <516454DA.9040109@redhat.com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig@mail.gmail.com> <87ppxzhfqy.fsf@fleche.redhat.com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig@mail.gmail.com> <516C2549.3060808@redhat.com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw@mail.gmail.com> <87vc7ithtj.fsf@fleche.redhat.com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw@mail.gmail.com> <87wqrrll9m.fsf@fleche.redhat.com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ@mail.gmail.com> <87d2t2tt02.fsf@fleche.redhat.com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg@mail.gmail.com> <87ehdehnc9.fsf@fleche.redhat.com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA@mail.gmail.com> <838v3masbd.fsf@gnu.org> <CANFwon0cXTz+X2A_3Fz1kuc40H64siGYGtO6CRKyGeMw88ca2Q@mail.gmail.com> <834ne6an8h.fsf@gnu.org> <CANFwon0fMc6efTtEVn_WLQ+8EaCzQ6f2AJH22jPg1RHyhnM2eg@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Mon, 20 May 2013 07:31:00 -0000
Message-ID: <CANFwon2V92hrOOvum+g5o+AFKLwNn+PsrKtskjdWJBoq95H_vg@mail.gmail.com>
Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, palves@redhat.com, hui_zhu@mentor.com, 	gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Content-Type: text/plain; charset=ISO-8859-1
X-SW-Source: 2013-05/txt/msg00716.txt.bz2

Ping http://sourceware.org/ml/gdb-patches/2013-05/msg00460.html

Thanks,
Hui

On Tue, May 14, 2013 at 12:56 PM, Hui Zhu <teawater@gmail.com> wrote:
> On Mon, May 13, 2013 at 11:55 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> From: Hui Zhu <teawater@gmail.com>
>>> Date: Mon, 13 May 2013 11:38:40 +0800
>>> Cc: tromey@redhat.com, palves@redhat.com, hui_zhu@mentor.com,
>>>       gdb-patches@sourceware.org, marc.khouzam@ericsson.com
>>>
>>> >> +If @var{location} cannot be parsed (for example if it
>>> >                                                   ^
>>> > A comma is missing.
>>>
>>> The comma is after the right parenthesis: refers to unknown files or functions),
>>> Do I need change this part to following format?
>>> If @var{location} cannot be parsed, (for example if it
>>> refers to unknown files or functions) create a pending
>>
>> No, I meant the comma after "for example", inside the parentheses.
>
> Fixed.
>
> Post a new version for it.
>
> Thanks,
> Hui
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * breakpoint.c (dprintf_breakpoint_ops): Remove its static.
>         * breakpoint.h (dprintf_breakpoint_ops): Add extern.
>         * mi/mi-cmd-break.c (ctype.h): New include.
>         (gdb_obstack.h): New include.
>         (mi_argv_to_format, mi_cmd_break_insert_1): New.
>         (mi_cmd_break_insert): Call mi_cmd_break_insert_1.
>         (mi_cmd_dprintf_insert): New.
>         * mi/mi-cmds.c (mi_cmds): Add "dprintf-insert".
>         * mi/mi-cmds.h (mi_cmd_dprintf_insert): New extern.
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * gdb.texinfo (GDB/MI Breakpoint Commands): Describe the
>         "-dprintf-insert" command.
>
> 2013-05-14  Hui Zhu  <hui@codesourcery.com>
>
>         * gdb.mi/Makefile.in (PROGS): Add "mi-dprintf".
>         * gdb.mi/mi-dprintf.exp, gdb.mi/mi-dprintf.c: New.