From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Don't disable the current display in throw_exception
Date: Tue, 09 Aug 2011 18:20:00 -0000 [thread overview]
Message-ID: <CAN9gPaHKQs3QfUbdPLRmECwNML7c41YoDvwsOmUuOyV_g68ecQ@mail.gmail.com> (raw)
In-Reply-To: <201108081528.23694.pedro@codesourcery.com>
On Mon, Aug 8, 2011 at 10:28 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Friday 05 August 2011 21:22:28, Daniel Jacobowitz wrote:
>> Seconded! Does this also fix the bug where if you display a variable,
>> and it is temporarily at a bad address, the display is disabled?
>
> Nope...
>
>> Or is that still the case? That always drives me nuts - yes, I know foo
>> is NULL, but I want GDB to go back to displaying *foo when it comes
>> back.
>
> That one doesn't look hard. Below's a quick patch at it (not regtested).
> Here's what I get:
>
> (top-gdb) display
> 2: *argv = 0x7fffffffe37c "/home/pedro/gdb/try_catch/build/gdb/gdb"
> (top-gdb) p argv = 0
> $2 = (char **) 0x0
> (top-gdb) display
> 2: *argv = <error: Cannot access memory at address 0x0>
At a glance, the patch looks good to me - and I think the output is a
huge improvement.
> Do I still get cookie? :-P :-)
Sure, here's one:
ID=ba7d44f129f0edf3:FF=0:TM=1312913790:LM=1312913790:S=DnGFaNl9wLPTTtLM
Careful what you ask for...
--
Thanks,
Daniel
prev parent reply other threads:[~2011-08-09 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 14:53 Pedro Alves
2011-08-05 15:10 ` Tom Tromey
2011-08-05 20:22 ` Daniel Jacobowitz
2011-08-08 14:28 ` Pedro Alves
2011-08-09 16:23 ` Don't disable displays on display eval error (Re: Don't disable the current display in throw_exception) Pedro Alves
2011-08-09 18:20 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN9gPaHKQs3QfUbdPLRmECwNML7c41YoDvwsOmUuOyV_g68ecQ@mail.gmail.com \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox