From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20451 invoked by alias); 9 Aug 2011 18:20:09 -0000 Received: (qmail 20437 invoked by uid 22791); 9 Aug 2011 18:20:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_RG X-Spam-Check-By: sourceware.org Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 18:19:53 +0000 Received: by ewy9 with SMTP id 9so206288ewy.0 for ; Tue, 09 Aug 2011 11:19:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.188.10 with SMTP id z10mr2037063eem.120.1312913991939; Tue, 09 Aug 2011 11:19:51 -0700 (PDT) Received: by 10.14.53.11 with HTTP; Tue, 9 Aug 2011 11:19:51 -0700 (PDT) In-Reply-To: <201108081528.23694.pedro@codesourcery.com> References: <201108051553.02017.pedro@codesourcery.com> <201108081528.23694.pedro@codesourcery.com> Date: Tue, 09 Aug 2011 18:20:00 -0000 Message-ID: Subject: Re: Don't disable the current display in throw_exception From: Daniel Jacobowitz To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00207.txt.bz2 On Mon, Aug 8, 2011 at 10:28 AM, Pedro Alves wrote: > On Friday 05 August 2011 21:22:28, Daniel Jacobowitz wrote: >> Seconded! =A0Does this also fix the bug where if you display a variable, >> and it is temporarily at a bad address, the display is disabled? > > Nope... > >> Or is that still the case? =A0That always drives me nuts - yes, I know f= oo >> is NULL, but I want GDB to go back to displaying *foo when it comes >> back. > > That one doesn't look hard. =A0Below's a quick patch at it (not regtested= ). > Here's what I get: > > (top-gdb) display > 2: *argv =3D 0x7fffffffe37c "/home/pedro/gdb/try_catch/build/gdb/gdb" > (top-gdb) p argv =3D 0 > $2 =3D (char **) 0x0 > (top-gdb) display > 2: *argv =3D At a glance, the patch looks good to me - and I think the output is a huge improvement. > Do I still get cookie? :-P :-) Sure, here's one: ID=3Dba7d44f129f0edf3:FF=3D0:TM=3D1312913790:LM=3D1312913790:S=3DDnGFaNl9= wLPTTtLM Careful what you ask for... --=20 Thanks, Daniel