Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <daniel.jacobowitz@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: asmwarrior <asmwarrior@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Linespec rewrite: Parsing
Date: Mon, 26 Mar 2012 00:40:00 -0000	[thread overview]
Message-ID: <CAN9gPaG6brAESNAHgSUXmndtAno+MDBxd7idLZ0XMCG8qR_UJQ@mail.gmail.com> (raw)
In-Reply-To: <4F6E0319.1080100@redhat.com>

On Sat, Mar 24, 2012 at 1:23 PM, Keith Seitz <keiths@redhat.com> wrote:
>
> On 03/24/2012 06:04 AM, asmwarrior wrote:
>
>> [debug]> break
>> "E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64"
>> [debug]unmatched quote
>
>
> This is now an illegal linespec. You do not need to quote this at all. This is one of the motivating factors for doing this rewrite: the quoting is _out of control_. [If you do want to quote it, ONLY quote the filename portion.]
>
> It appears you may be using the patches I submitted to the list. I've committed one or two additional patches for problems I've found to the archer branch, one of which deal specifically with quoting and embedded colons.
>
> I encourage you to try that branch:
>
> (gdb) break E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64
>
> No source file named E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp.
>
> Leaving the quoting in place will force the lookup of the function "E:/.../token.cpp:64", which I'm guessing is not what you really want. :-)

This is the change of behavior I think most likely to blow up.
-break-insert proxies straight through to the CLI break command; have
you checked what various other IDEs send today?

Is a special case (yeah, I know) for a quoted function ending in
:[0-9]* practical?

--
Thanks,
Daniel


  parent reply	other threads:[~2012-03-26  0:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 21:21 Keith Seitz
2012-03-20  3:56 ` Eli Zaretskii
2012-03-20  5:31   ` Keith Seitz
2012-03-20 17:26     ` Eli Zaretskii
2012-03-24 13:03 ` asmwarrior
2012-03-24 17:23   ` Keith Seitz
2012-03-25 12:27     ` asmwarrior
2012-03-26 13:23       ` asmwarrior
2012-03-25 12:28     ` asmwarrior
2012-03-26  0:40     ` Daniel Jacobowitz [this message]
2012-03-26 16:26       ` Tom Tromey
2012-03-26 18:52         ` Keith Seitz
2012-03-26 19:05       ` André Pönitz
2012-03-26 19:31 ` Tom Tromey
2012-03-26 20:36   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN9gPaG6brAESNAHgSUXmndtAno+MDBxd7idLZ0XMCG8qR_UJQ@mail.gmail.com \
    --to=daniel.jacobowitz@gmail.com \
    --cc=asmwarrior@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox