From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16439 invoked by alias); 26 Mar 2012 00:40:07 -0000 Received: (qmail 16429 invoked by uid 22791); 26 Mar 2012 00:40:06 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_SM X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 00:39:42 +0000 Received: by eaal1 with SMTP id l1so1401197eaa.0 for ; Sun, 25 Mar 2012 17:39:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.119.197 with SMTP id n45mr2685042eeh.46.1332722381269; Sun, 25 Mar 2012 17:39:41 -0700 (PDT) Received: by 10.14.38.213 with HTTP; Sun, 25 Mar 2012 17:39:41 -0700 (PDT) In-Reply-To: <4F6E0319.1080100@redhat.com> References: <4F67A319.4090608@redhat.com> <4F6DC651.6060704@gmail.com> <4F6E0319.1080100@redhat.com> Date: Mon, 26 Mar 2012 00:40:00 -0000 Message-ID: Subject: Re: [RFA 1/3] Linespec rewrite: Parsing From: Daniel Jacobowitz To: Keith Seitz Cc: asmwarrior , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00861.txt.bz2 On Sat, Mar 24, 2012 at 1:23 PM, Keith Seitz wrote: > > On 03/24/2012 06:04 AM, asmwarrior wrote: > >> [debug]> break >> "E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64" >> [debug]unmatched quote > > > This is now an illegal linespec. You do not need to quote this at all. This is one of the motivating factors for doing this rewrite: the quoting is _out of control_. [If you do want to quote it, ONLY quote the filename portion.] > > It appears you may be using the patches I submitted to the list. I've committed one or two additional patches for problems I've found to the archer branch, one of which deal specifically with quoting and embedded colons. > > I encourage you to try that branch: > > (gdb) break E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64 > > No source file named E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp. > > Leaving the quoting in place will force the lookup of the function "E:/.../token.cpp:64", which I'm guessing is not what you really want. :-) This is the change of behavior I think most likely to blow up. -break-insert proxies straight through to the CLI break command; have you checked what various other IDEs send today? Is a special case (yeah, I know) for a quoted function ending in :[0-9]* practical? -- Thanks, Daniel