From: Mark Williams <mark@myosotissp.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix toplevel types with -fdebug-types-section
Date: Sat, 18 Jan 2020 18:59:00 -0000 [thread overview]
Message-ID: <CAN0QdPU2EH85WuDUx4rWuGXW3vS_L+520O9eVqskzrTu7AXbWg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
Per https://sourceware.org/bugzilla/show_bug.cgi?id=24480 toplevel
types were broken by
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=93b8bea4143cafae79076076c64aaa4c46a9b73c
because it only set list_in_scope in start_sym_tab. With type-units,
It also needs to be set when re-opening a symtab.
Mark
[-- Attachment #2: 0001-gdb-Fix-toplevel-types-with-fdebug-types-section.patch --]
[-- Type: application/octet-stream, Size: 1285 bytes --]
From 87fd17d7cc15fc0e49c4afe30edb2faf8f2b83a9 Mon Sep 17 00:00:00 2001
From: mwilliams <mwilliams@fb.com>
Date: Wed, 15 Jan 2020 20:19:39 -0800
Subject: [PATCH] gdb: Fix toplevel types with -fdebug-types-section
When debugging a program compiled with -fdebug-types-section,
only the first top-level type in each file is visible to gdb.
gdb/Changelog
2020-01-18 Mark Williams <mark@myosotissp.com>
PR gdb/24480
* dwarf2read.c add missing assingments to list_in_scope when
start_symtab was already called.
---
gdb/dwarf2read.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index d1b65b7bc3..c8f0d27f91 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -11762,6 +11762,7 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
COMPUNIT_DIRNAME (cust),
compunit_language (cust),
0, cust));
+ list_in_scope = get_builder ()->get_file_symbols ();
}
return;
}
@@ -11813,6 +11814,7 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
COMPUNIT_DIRNAME (cust),
compunit_language (cust),
0, cust));
+ list_in_scope = get_builder ()->get_file_symbols ();
auto &file_names = line_header->file_names ();
for (i = 0; i < file_names.size (); ++i)
--
2.17.1
next reply other threads:[~2020-01-18 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 18:59 Mark Williams [this message]
2020-01-19 2:04 ` Simon Marchi
2020-01-19 2:10 ` Simon Marchi
2020-01-19 16:31 ` Mark Williams
2020-01-19 16:40 ` Simon Marchi
2020-01-21 19:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0QdPU2EH85WuDUx4rWuGXW3vS_L+520O9eVqskzrTu7AXbWg@mail.gmail.com \
--to=mark@myosotissp.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox