Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Mark Williams <mark@myosotissp.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix toplevel types with -fdebug-types-section
Date: Sun, 19 Jan 2020 02:04:00 -0000	[thread overview]
Message-ID: <79aec7d1-787d-1693-c0b7-b8bb53cdf3b4@simark.ca> (raw)
In-Reply-To: <CAN0QdPU2EH85WuDUx4rWuGXW3vS_L+520O9eVqskzrTu7AXbWg@mail.gmail.com>

On 2020-01-18 1:53 p.m., Mark Williams wrote:
> Per https://sourceware.org/bugzilla/show_bug.cgi?id=24480 toplevel
> types were broken by
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=93b8bea4143cafae79076076c64aaa4c46a9b73c
> because it only set list_in_scope in start_sym_tab. With type-units,
> It also needs to be set when re-opening a symtab.
> 
> Mark
> 

Hi Mark,

Thanks for sending a patch.

Can you please put a bit more information in the commit message?  In particular:

- An illustration of the problem, and how to reproduce it
- Why/how this patch fixes the problem

There are good elements about that in the bug report discussions, it's just a matter
of synthesizing them in the commit message.

Thanks,

Simon


  reply	other threads:[~2020-01-19  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 18:59 Mark Williams
2020-01-19  2:04 ` Simon Marchi [this message]
2020-01-19  2:10   ` Simon Marchi
2020-01-19 16:31     ` Mark Williams
2020-01-19 16:40       ` Simon Marchi
2020-01-21 19:56       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79aec7d1-787d-1693-c0b7-b8bb53cdf3b4@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=mark@myosotissp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox