From: Max Filippov <jcmvbkbc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Maxim Grigoriev <maxim2405@gmail.com>,
Woody LaRue <larue@cadence.com>,
Marc Gauthier <marc@cadence.com>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>
Subject: Re: [PATCH 0/2] xtensa: add hardware breakpoints support
Date: Thu, 10 Mar 2016 20:18:00 -0000 [thread overview]
Message-ID: <CAMo8BfKHboXkR73_g8QHAoGddeeNGXun78EUCidGUJBGzUxLWA@mail.gmail.com> (raw)
In-Reply-To: <56E1AC20.30405@redhat.com>
On Thu, Mar 10, 2016 at 8:17 PM, Pedro Alves <palves@redhat.com> wrote:
> On 03/09/2016 09:48 PM, Max Filippov wrote:
>>
>> Hello,
>>
>> this series cleans up gdb/xtensa-linux-nat.c so that it builds without
>> warnings and adds support for hardware breakpoints and watchpoints.
>> The implementation closely follows what ARM does.
>> Please review.
>
>
> Unfortunately, you looked at one of the targets that still doesn't
> share the debug registers code with gdbserver. See how at least
> x86, aarch64 and mips put debug registers code in gdb/nat/.
Will do, thanks for the tip.
> I think we should require all new GNU/Linux debug registers
> support code follow such a scheme.
>
> Patch #1 is obvious, please push it in.
Hmm, this is already fixed on master, sorry for the noise.
--
Thanks.
-- Max
prev parent reply other threads:[~2016-03-10 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 21:48 Max Filippov
2016-03-09 21:48 ` [PATCH 1/2] gdb: xtensa: make locally used functions static Max Filippov
2016-03-09 21:49 ` [PATCH 2/2] gdb: xtensa: support hardware breakpoints/watchpoints Max Filippov
2016-03-10 17:17 ` [PATCH 0/2] xtensa: add hardware breakpoints support Pedro Alves
2016-03-10 20:18 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfKHboXkR73_g8QHAoGddeeNGXun78EUCidGUJBGzUxLWA@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=larue@cadence.com \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marc@cadence.com \
--cc=maxim2405@gmail.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox