From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116579 invoked by alias); 10 Mar 2016 20:18:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116547 invoked by uid 89); 10 Mar 2016 20:18:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=noise, H*Ad:D*cadence.com, tip X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 10 Mar 2016 20:18:10 +0000 Received: by mail-oi0-f49.google.com with SMTP id m82so70153751oif.1 for ; Thu, 10 Mar 2016 12:18:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=HEXcpKgmaoI8DucelvI0lU0CWnbLohDRCjTqBZZ3Q/s=; b=lqY7MvmdMHkC8L2lcIuJmGGJYkOjihn1jVXzuzjLD6ZmW2EXT7PG1R8rQP25ujZ+vd KzjW/p/QfCapizuUxgBvjBg/ItlaS6E+Yu6TZc9/AqW/o3oR8VPwyICJ7bqIBqTRnYMN q2Oac3cYFq39QoYHO17MfOytDfPPto3jRUEQraF/sgjUfDGmpNfkSxHxHZE6qkif/uWW i00IQbixX63aOgaUQe8wLUcPbm5DmeCUUddKTsrfL96QX33Yzk08fAl5tzdZkR3WgFBb DmTI5yVh0+nnICjk9BbYwtxl/1U3ngE0Jyi5OHOUb0XMioIQj4uHvvghaBF7uCcT5bZw 6SsQ== X-Gm-Message-State: AD7BkJJj4xe/MXlyOpDOG+gYRcdqq81kzkddh+yp1AO1GESlFIact81jsF8A43t0RnPgjFjCnMIBcV6Qgqw2xg== MIME-Version: 1.0 X-Received: by 10.202.240.68 with SMTP id o65mr3343342oih.0.1457641088401; Thu, 10 Mar 2016 12:18:08 -0800 (PST) Received: by 10.76.27.232 with HTTP; Thu, 10 Mar 2016 12:18:08 -0800 (PST) In-Reply-To: <56E1AC20.30405@redhat.com> References: <1457560106-5830-1-git-send-email-jcmvbkbc@gmail.com> <56E1AC20.30405@redhat.com> Date: Thu, 10 Mar 2016 20:18:00 -0000 Message-ID: Subject: Re: [PATCH 0/2] xtensa: add hardware breakpoints support From: Max Filippov To: Pedro Alves Cc: gdb-patches@sourceware.org, Maxim Grigoriev , Woody LaRue , Marc Gauthier , "linux-xtensa@linux-xtensa.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-03/txt/msg00165.txt.bz2 On Thu, Mar 10, 2016 at 8:17 PM, Pedro Alves wrote: > On 03/09/2016 09:48 PM, Max Filippov wrote: >> >> Hello, >> >> this series cleans up gdb/xtensa-linux-nat.c so that it builds without >> warnings and adds support for hardware breakpoints and watchpoints. >> The implementation closely follows what ARM does. >> Please review. > > > Unfortunately, you looked at one of the targets that still doesn't > share the debug registers code with gdbserver. See how at least > x86, aarch64 and mips put debug registers code in gdb/nat/. Will do, thanks for the tip. > I think we should require all new GNU/Linux debug registers > support code follow such a scheme. > > Patch #1 is obvious, please push it in. Hmm, this is already fixed on master, sorry for the noise. -- Thanks. -- Max