Re: PATCH: Convert siginfo for x32 in gdbserver

["H.J. Lu" <hjl.tools@gmail.com>]

On Thu, Apr 12, 2012 at 12:40 PM, Pedro Alves <palves@redhat.com> wrote:
> On 04/12/2012 06:20 PM, H.J. Lu wrote:
>
>>  /* Convert a native/host siginfo object, into/from the siginfo in the
>> @@ -938,6 +1113,21 @@ x86_siginfo_fixup (siginfo_t *native, void *inf, int direction)
>>
>>        return 1;
>>      }
>> +  /* No fixup for native x32 GDB.  */
>> +  else if (sizeof (void *) == 8)
>
>
> I'm confused.  Isn't this _also_ reached when both the inferior and gdbserver are 64-bit?
> There should also be no fixup then.

Oops.  I need to check the inferior isn't 64-bit.

>> +    {
>> +      if (sizeof (siginfo_t) != sizeof (compat_siginfo_t))
>
>
>      if (sizeof (siginfo_t) != sizeof (compat_x32_siginfo_t))
>

Fixed.   I posted an updated patch.

Thanks.

-- 
H.J.