From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89790-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31459 invoked by alias); 12 Apr 2012 20:27:15 -0000
Received: (qmail 31438 invoked by uid 22791); 12 Apr 2012 20:27:13 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Apr 2012 20:27:01 +0000
Received: by qafl39 with SMTP id l39so5083071qaf.14        for <gdb-patches@sourceware.org>; Thu, 12 Apr 2012 13:27:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.189.137 with SMTP id de9mr6019176qab.45.1334262420323; Thu, 12 Apr 2012 13:27:00 -0700 (PDT)
Received: by 10.229.136.69 with HTTP; Thu, 12 Apr 2012 13:27:00 -0700 (PDT)
In-Reply-To: <4F872F9B.7090207@redhat.com>
References: <20120412172000.GA7985@intel.com>	<4F872F9B.7090207@redhat.com>
Date: Thu, 12 Apr 2012 20:58:00 -0000
Message-ID: <CAMe9rOr_-HJMozq=kBd_GZdEXM1WeRPeS9qs139-V25P0NBOJw@mail.gmail.com>
Subject: Re: PATCH: Convert siginfo for x32 in gdbserver
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00325.txt.bz2

On Thu, Apr 12, 2012 at 12:40 PM, Pedro Alves <palves@redhat.com> wrote:
> On 04/12/2012 06:20 PM, H.J. Lu wrote:
>
>> =A0/* Convert a native/host siginfo object, into/from the siginfo in the
>> @@ -938,6 +1113,21 @@ x86_siginfo_fixup (siginfo_t *native, void *inf, i=
nt direction)
>>
>> =A0 =A0 =A0 =A0return 1;
>> =A0 =A0 =A0}
>> + =A0/* No fixup for native x32 GDB. =A0*/
>> + =A0else if (sizeof (void *) =3D=3D 8)
>
>
> I'm confused. =A0Isn't this _also_ reached when both the inferior and gdb=
server are 64-bit?
> There should also be no fixup then.

Oops.  I need to check the inferior isn't 64-bit.

>> + =A0 =A0{
>> + =A0 =A0 =A0if (sizeof (siginfo_t) !=3D sizeof (compat_siginfo_t))
>
>
> =A0 =A0 =A0if (sizeof (siginfo_t) !=3D sizeof (compat_x32_siginfo_t))
>

Fixed.   I posted an updated patch.

Thanks.

--=20
H.J.