Re: Oh dear. I regret to inform you that commit 'ELF: Check ELF_COMMON_DEF_P for common symbols' might be unfortunate

Re: Oh dear. I regret to inform you that commit 'ELF: Check ELF_COMMON_DEF_P for common symbols' might be unfortunate

[H.J. Lu]

On Fri, Apr 7, 2017 at 7:53 AM,  <gdb-buildbot@sergiodj.net> wrote:
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
>         ELF: Check ELF_COMMON_DEF_P for common symbols
>         8170f7693bc0a9442c0aa280197925db92d48ca6
>
> might have made GDB unwell.  Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.
>
> Please note that if you are reading this message on gdb-patches, there might
> be other builders broken.
>
> You can find more details about the unfortunate breakage below.
>
> Cheers,
>
> Your GDB BuildBot.
>

Could someone please fix this?  The problem is

../../binutils-gdb/opcodes/wasm32-dis.c:408:34: error: ‘DECIMAL_DIG’
undeclared (first use in this function)
           prin (stream, " %.*g", DECIMAL_DIG, fconstant);
                                  ^
../../binutils-gdb/opcodes/wasm32-dis.c:408:34: note: each undeclared
identifier is reported only once for each function it appears in
make[4]: *** [wasm32-dis.lo] Error 1
make[4]: *** Waiting for unfinished jobs....

which has nothing to do with my commit.


H.J.

Re: Oh dear. I regret to inform you that commit 'ELF: Check ELF_COMMON_DEF_P for common symbols' might be unfortunate

[Yao Qi]

On Fri, Apr 7, 2017 at 4:03 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Could someone please fix this?  The problem is
>
> ../../binutils-gdb/opcodes/wasm32-dis.c:408:34: error: ‘DECIMAL_DIG’
> undeclared (first use in this function)
>            prin (stream, " %.*g", DECIMAL_DIG, fconstant);
>                                   ^
> ../../binutils-gdb/opcodes/wasm32-dis.c:408:34: note: each undeclared
> identifier is reported only once for each function it appears in
> make[4]: *** [wasm32-dis.lo] Error 1
> make[4]: *** Waiting for unfinished jobs....
>
> which has nothing to do with my commit.
>

The patch is being reviewed,
https://sourceware.org/ml/binutils/2017-04/msg00066.html

-- 
Yao (齐尧)