From: David Albert <davidbalbert@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Scan for Mach-O start address in LC_MAIN and properly check bfd_mach_o_scan_start_address's return value
Date: Fri, 23 Nov 2012 19:58:00 -0000 [thread overview]
Message-ID: <CAKYxTUa3WfNcwCnn5tLeygP6wmbptZPF9AWm-dOAL28cRhqZtQ@mail.gmail.com> (raw)
In-Reply-To: <874nklsj9d.fsf@fleche.redhat.com>
On Mon, Nov 19, 2012 at 10:30 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "David" == David Albert <davidbalbert@gmail.com> writes:
>
> David> - I didn't run the test suite because it wasn't clear what parts of
> David> the suite I should run. I tested it manually and didn't find any
> David> regressions.
>
> Unfortunately, what you have to do is run the entire test suite before
> and after your change, and verify that there were no regressions or
> dropped tests. Also you have to know that some tests fail spuriously --
> I guess you could post a list of differences and someone could advise.
Sorry I missed this. I ran the binutils test suite before submitting.
-David
>
> Tom
prev parent reply other threads:[~2012-11-23 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 4:13 David Albert
2012-11-19 4:48 ` Joel Brobecker
2012-11-19 5:03 ` David Albert
2012-11-19 5:06 ` Andrew Pinski
2012-11-19 5:18 ` David Albert
2012-11-19 16:28 ` Tom Tromey
2012-11-23 19:58 ` David Albert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYxTUa3WfNcwCnn5tLeygP6wmbptZPF9AWm-dOAL28cRhqZtQ@mail.gmail.com \
--to=davidbalbert@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox