From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26024 invoked by alias); 23 Nov 2012 19:58:07 -0000 Received: (qmail 26015 invoked by uid 22791); 23 Nov 2012 19:58:06 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Nov 2012 19:58:01 +0000 Received: by mail-pa0-f41.google.com with SMTP id bj3so2718555pad.0 for ; Fri, 23 Nov 2012 11:58:01 -0800 (PST) Received: by 10.68.247.196 with SMTP id yg4mr16881802pbc.167.1353700681230; Fri, 23 Nov 2012 11:58:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.153.131 with HTTP; Fri, 23 Nov 2012 11:57:40 -0800 (PST) In-Reply-To: <874nklsj9d.fsf@fleche.redhat.com> References: <874nklsj9d.fsf@fleche.redhat.com> From: David Albert Date: Fri, 23 Nov 2012 19:58:00 -0000 Message-ID: Subject: Re: [PATCH] Scan for Mach-O start address in LC_MAIN and properly check bfd_mach_o_scan_start_address's return value To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00631.txt.bz2 On Mon, Nov 19, 2012 at 10:30 AM, Tom Tromey wrote: >>>>>> "David" == David Albert writes: > > David> - I didn't run the test suite because it wasn't clear what parts of > David> the suite I should run. I tested it manually and didn't find any > David> regressions. > > Unfortunately, what you have to do is run the entire test suite before > and after your change, and verify that there were no regressions or > dropped tests. Also you have to know that some tests fail spuriously -- > I guess you could post a list of differences and someone could advise. Sorry I missed this. I ran the binutils test suite before submitting. -David > > Tom