Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Delete temporary string within demangler even in failure cases.
Date: Tue, 27 May 2014 13:47:00 -0000	[thread overview]
Message-ID: <CAKOQZ8x4wmbgnkj7YN+iojxN-3fHDrd8fqCLSny31Q=NHzmV6w@mail.gmail.com> (raw)
In-Reply-To: <1401188253-15214-1-git-send-email-aburgess@broadcom.com>

On Tue, May 27, 2014 at 3:57 AM, Andrew Burgess <aburgess@broadcom.com> wrote:
>
> libiberty/ChangeLog
>
>         * cplus-dem.c (do_type): Call string_delete even if the call to
>         demangle_template fails.

This is OK.

Thanks.

I have to ask: you know this code is not used, right?  You're looking
at the old demangler, for symbols generated by versions of g++ before
GCC 3.4 (released 2004).  The demangler for current versions of g++ is
in cp-demangle.c.

Ian


  reply	other threads:[~2014-05-27 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 10:57 Andrew Burgess
2014-05-27 13:47 ` Ian Lance Taylor [this message]
2014-06-10 18:08   ` Andrew Burgess
2014-06-11 11:02     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKOQZ8x4wmbgnkj7YN+iojxN-3fHDrd8fqCLSny31Q=NHzmV6w@mail.gmail.com' \
    --to=iant@google.com \
    --cc=aburgess@broadcom.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox