From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24362 invoked by alias); 27 May 2014 13:47:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24284 invoked by uid 89); 27 May 2014 13:47:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: mail-oa0-f43.google.com Received: from mail-oa0-f43.google.com (HELO mail-oa0-f43.google.com) (209.85.219.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 27 May 2014 13:47:32 +0000 Received: by mail-oa0-f43.google.com with SMTP id l6so9609590oag.16 for ; Tue, 27 May 2014 06:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nV/jYAyPAT212EmS0XJBsqyjSr2+GE/MhK3ECAd42YU=; b=IUvwc6LiHzcIVpm4kc93aHlXn2VIAyvxnxT3Ntigq2gFnnk/FiicPJBT4FsMVracBe jh+F2jOptGlkWwipwKTQlq1C346tgyGYvToPa4EXcfmEpEOg/K1urpADTS+cyLjqO19t qsfLuHGrA3Wv/o6NHqRG/Vj7eEvfCOLQVJ8tbSPb3xtHuQn0XfxNFwuQdeUnQfa2IeR6 2QnnzAnYP2KJwXEWA+T2JOmYczBTmD16lVywiRaYsorqYchzItW6yDhwiW/6fYs7GrG2 O9nEVokahgppRjDxBwRoIDyJ64K2gHWsn1ibsHOlmAc0T9ec0n9u6wm4LFrWcZcvgE0E LWEg== X-Gm-Message-State: ALoCoQkT79phnlc8a0rBpQ+PUOkGQDOWuvKjAUUi01iAavvsSkvbFqxV8Y4cRAMZ6lgQ0ECxs0R0 MIME-Version: 1.0 X-Received: by 10.182.74.234 with SMTP id x10mr32277687obv.1.1401198451076; Tue, 27 May 2014 06:47:31 -0700 (PDT) Received: by 10.60.118.39 with HTTP; Tue, 27 May 2014 06:47:30 -0700 (PDT) In-Reply-To: <1401188253-15214-1-git-send-email-aburgess@broadcom.com> References: <1401188253-15214-1-git-send-email-aburgess@broadcom.com> Date: Tue, 27 May 2014 13:47:00 -0000 Message-ID: Subject: Re: [PATCH] Delete temporary string within demangler even in failure cases. From: Ian Lance Taylor To: Andrew Burgess Cc: gcc-patches , gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-05/txt/msg00668.txt.bz2 On Tue, May 27, 2014 at 3:57 AM, Andrew Burgess wrote: > > libiberty/ChangeLog > > * cplus-dem.c (do_type): Call string_delete even if the call to > demangle_template fails. This is OK. Thanks. I have to ask: you know this code is not used, right? You're looking at the old demangler, for symbols generated by versions of g++ before GCC 3.4 (released 2004). The demangler for current versions of g++ is in cp-demangle.c. Ian