Re: [PATCH v2] ARM Linux support for `catch syscall'

[Samuel Bronson <naesten@gmail.com>]

On Wed, Aug 14, 2013 at 3:29 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
>
> Hi Samuel,
>
> Thanks for the patch.  A few comments.
>
> On Wednesday, July 31 2013, Samuel Bronson wrote:
>
> > This time, it passes all the tests and comes with a nearly complete
> > XML file (plus a script that can nearly regenerate the XML file).
>
> So the XML file is not complete?  What's missing?  IMO it should
> certainly be complete, even if the script can't generate it entirely (in
> which case it should be hand editted).

Well the only thing I know is missing is __ARM_NR_cmpxchg; it's a
little hard to tell about the others.  It has every syscall actually
listed for userspace as of the tag v3.11-rc5, plus the obvious removed
ones.

> > +    m = re.match(r'^\s+/\* (\d+) was sys_(\w+) \*/$', line)
> > +    if m:
> > +        record(m.group(2), int(m.group(1)), 'removed')
>
> I don't get the 'removed' comment.  Looking at
> <include/linux/arch/arm/include/uapi/asm/unistd.h>, I don't see the
> syscalls marked as "removed" in the XML file below.  Where did they come
> from?

(It seems that Sergio was looking at a bad copy of the headers, since resolved.)