From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30524 invoked by alias); 16 Aug 2013 18:50:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30513 invoked by uid 89); 16 Aug 2013 18:50:58 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.2 Received: from mail-lb0-f174.google.com (HELO mail-lb0-f174.google.com) (209.85.217.174) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 16 Aug 2013 18:50:53 +0000 Received: by mail-lb0-f174.google.com with SMTP id w20so1645167lbh.5 for ; Fri, 16 Aug 2013 11:50:50 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.18.130 with SMTP id w2mr41750lbd.51.1376679050592; Fri, 16 Aug 2013 11:50:50 -0700 (PDT) Received: by 10.112.80.102 with HTTP; Fri, 16 Aug 2013 11:50:50 -0700 (PDT) In-Reply-To: References: Date: Fri, 16 Aug 2013 18:50:00 -0000 Message-ID: Subject: Re: [PATCH v2] ARM Linux support for `catch syscall' From: Samuel Bronson To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org, Doug Evans Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2013-08/txt/msg00448.txt.bz2 On Wed, Aug 14, 2013 at 3:29 PM, Sergio Durigan Junior wrote: > > Hi Samuel, > > Thanks for the patch. A few comments. > > On Wednesday, July 31 2013, Samuel Bronson wrote: > > > This time, it passes all the tests and comes with a nearly complete > > XML file (plus a script that can nearly regenerate the XML file). > > So the XML file is not complete? What's missing? IMO it should > certainly be complete, even if the script can't generate it entirely (in > which case it should be hand editted). Well the only thing I know is missing is __ARM_NR_cmpxchg; it's a little hard to tell about the others. It has every syscall actually listed for userspace as of the tag v3.11-rc5, plus the obvious removed ones. > > + m = re.match(r'^\s+/\* (\d+) was sys_(\w+) \*/$', line) > > + if m: > > + record(m.group(2), int(m.group(1)), 'removed') > > I don't get the 'removed' comment. Looking at > , I don't see the > syscalls marked as "removed" in the XML file below. Where did they come > from? (It seems that Sergio was looking at a bad copy of the headers, since resolved.)