Re: [PATCH 2/2] mangle_style: Add new DWARF5 constants

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Mon, Dec 9, 2024 at 11:51 AM Rohr, Stephan <stephan.rohr@intel.com>
wrote:

> Hi Alexandra,
>
> just a small nit.
>
> Stephan
>
> > -----Original Message-----
> > From: Alexandra Hájková <ahajkova@redhat.com>
> > Sent: Monday, 9 December 2024 11:21
> > To: gdb-patches@sourceware.org
> > Cc: ahajkova@redhat.com
> > Subject: [PATCH 2/2] mangle_style: Add new DWARF5 constants
> >
> > Update bfd/dwarf2.c with the new DWARF5 language codes to
> > make it possible to return the mangling style for the new
> > language codes for Ada 2005 and 20015, Fortran 18 and 23,
> > C++ 20 and 23, C 17 and 23 and Assembly.
> > ---
> >  bfd/dwarf2.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> > index 151ed0237ca..ec298764c8a 100644
> > --- a/bfd/dwarf2.c
> > +++ b/bfd/dwarf2.c
> > @@ -1725,12 +1725,16 @@ mangle_style (int lang)
> >      {
> >      case DW_LANG_Ada83:
> >      case DW_LANG_Ada95:
> > +    case DW_LANG_Ada2005:
> > +    case DW_LANG_Ada2012:
> >        return DMGL_GNAT;
> >
> >      case DW_LANG_C_plus_plus:
> >      case DW_LANG_C_plus_plus_03:
> >      case DW_LANG_C_plus_plus_11:
> >      case DW_LANG_C_plus_plus_14:
> > +    case DW_LANG_C_plus_plus_20:
> > +    case DW_LANG_C_plus_plus_23:
> >        return DMGL_GNU_V3;
> >
>
> Should we add `DW_LANG_C_plus_plus_17`, too?
>
> You re absolutely right, I forgot to add it.
>

Thank you!

[-- Attachment #2: Type: text/html, Size: 2257 bytes --]