From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2EcsDiIQV2frgAkAWB0awg (envelope-from ) for ; Mon, 09 Dec 2024 10:43:30 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YDsuNHuw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3724F1E097; Mon, 9 Dec 2024 10:43:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0CB11E091 for ; Mon, 9 Dec 2024 10:43:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D792385842D for ; Mon, 9 Dec 2024 15:43:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D792385842D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YDsuNHuw Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C36063858423 for ; Mon, 9 Dec 2024 15:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C36063858423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C36063858423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733758971; cv=none; b=Q0OgYZ9yvV3jbmXjZ7NstUr0ubF3OMr89ME37zlnykxYLWpmwWfoTeAlfxCMHtPkZsYAhKyA89wmU/3c6JZWWWLW2b9B4NK0BpZAjqbKhFED6VkZFDT9RHb4daq2M/e7nPlEgG5SKZ0bbh+GzZ9WexOn3m7kS/MI9OwBRYzIy2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733758971; c=relaxed/simple; bh=kSETvw8/5xrTH8zOmNlPbiQs51/4qZyZUnkA6bU22NQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=olxIk/JSm2hkp4TEGrPxZ69ir1swUKDVR11iU8JwEbfMJqUqaQii0Cq3OhxKfA4juQvlysx5S1ZGKPB5x0tUweEuS8/8TlPBS/fGRdczcf2hLOR0xct/haAM/6XALOt5tW/VvOcmSztkGIPY7pUEIi3zyyRW96IUaV7VWS7Rwto= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C36063858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733758971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jZqHOzpdods5Y/kOuuqv013EqmZF3XUdedQJjkAKrLA=; b=YDsuNHuwrCNOLHRTzLpjaOECkwuhDoOzsqAo/1G15az1aUcrgdyvDES0mtwAIH6X7g+5LO hJCYdKgbKmpNhU8axjqAeTjPMwelWJ4wzaLZlf6/cL29hDawl1uzarBbTFHBtRMuuVU10I 7p+z1U/TPEKY/CZ7SvtVW7nx9pz0Zw0= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-uPJgYC_GPtKhASAbpKUxrg-1; Mon, 09 Dec 2024 10:42:50 -0500 X-MC-Unique: uPJgYC_GPtKhASAbpKUxrg-1 X-Mimecast-MFC-AGG-ID: uPJgYC_GPtKhASAbpKUxrg Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2ef9b9981f1so2320487a91.3 for ; Mon, 09 Dec 2024 07:42:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733758969; x=1734363769; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jZqHOzpdods5Y/kOuuqv013EqmZF3XUdedQJjkAKrLA=; b=TYoVuOxqW/y0jkuUJ+zxtFuAltsXpvCRR+XUXpVS/syr9ZmNCtQojbd1McIqcnQqlc AwMTigtLS2nRHLOYRg0qyJLDvymMVFfZz1n36oWOR/nJ53UVX2o320ugVw+s942Hk41b MVbn+V7fedbmf60zxN7g1pmQyqnqJHr7DPvQQ+prJuo/iqqDr1ljy8j6z6BgQUF+Ml6o p8megzgDWc3g04qUxOqDzdX88BcRcY4h+bCvf9NHs6TmaplfyaHtKrqgA2hzn59/jBlY ZveCqROz3feGXQ9d0FF8BWAZXHCRzq5QJvl45lORRI/tcyctLrOikWx7/9U4A7lSXs0i 4VXQ== X-Gm-Message-State: AOJu0YwrK3/qGTh0OlYn5dOYnKBzC24B1C2auX6IDqYHpl/WpBPyOoFd spto8xTO0SJsja5TZsPPAPos1VeMNjArqaetjRVjN+3GZYdYi4WHFx7t5Cm8Q2fK5h1h+LZlxL2 euViXRtaljuqzxJBouTyNQ0P2BCfiOcqMb8SuDWQmL/dy34NgK5pNcAloaHfRLBjTzMP4lZSDCJ FHa9mxOVQe234pQN3mpxOSjJwespqDvMVpRA== X-Gm-Gg: ASbGncukvn1uhSqqWULLVmaUjpWSRhC4bV+BZ/RHf+hONv7IDGbpyUrOvSURLFEQvIn aKrdxIIPvvqEQlb3BN9RaJs1VTufLUHrEVg== X-Received: by 2002:a17:90b:3887:b0:2ee:ab11:fab2 with SMTP id 98e67ed59e1d1-2efcf1cf51bmr1328990a91.22.1733758969228; Mon, 09 Dec 2024 07:42:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEG2Woh7lyphRQ592yvPzwYjLnoB2JoFcCxubiQYkcImoOvGbmjD5dCp+0yhBmK+zCdRFjNCAmsT7xVqd1F5Eo= X-Received: by 2002:a17:90b:3887:b0:2ee:ab11:fab2 with SMTP id 98e67ed59e1d1-2efcf1cf51bmr1328953a91.22.1733758968721; Mon, 09 Dec 2024 07:42:48 -0800 (PST) MIME-Version: 1.0 References: <20241209102116.612361-1-ahajkova@redhat.com> <20241209102116.612361-2-ahajkova@redhat.com> In-Reply-To: From: Alexandra Petlanova Hajkova Date: Mon, 9 Dec 2024 16:37:59 +0100 Message-ID: Subject: Re: [PATCH 2/2] mangle_style: Add new DWARF5 constants To: "Rohr, Stephan" Cc: "gdb-patches@sourceware.org" X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bqpwkLV7VxuW6Qw3IKPzFv-N_PNzlfSnmTvPp9wmgRs_1733758969 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000750fb50628d8370e" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000750fb50628d8370e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 9, 2024 at 11:51=E2=80=AFAM Rohr, Stephan wrote: > Hi Alexandra, > > just a small nit. > > Stephan > > > -----Original Message----- > > From: Alexandra H=C3=A1jkov=C3=A1 > > Sent: Monday, 9 December 2024 11:21 > > To: gdb-patches@sourceware.org > > Cc: ahajkova@redhat.com > > Subject: [PATCH 2/2] mangle_style: Add new DWARF5 constants > > > > Update bfd/dwarf2.c with the new DWARF5 language codes to > > make it possible to return the mangling style for the new > > language codes for Ada 2005 and 20015, Fortran 18 and 23, > > C++ 20 and 23, C 17 and 23 and Assembly. > > --- > > bfd/dwarf2.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c > > index 151ed0237ca..ec298764c8a 100644 > > --- a/bfd/dwarf2.c > > +++ b/bfd/dwarf2.c > > @@ -1725,12 +1725,16 @@ mangle_style (int lang) > > { > > case DW_LANG_Ada83: > > case DW_LANG_Ada95: > > + case DW_LANG_Ada2005: > > + case DW_LANG_Ada2012: > > return DMGL_GNAT; > > > > case DW_LANG_C_plus_plus: > > case DW_LANG_C_plus_plus_03: > > case DW_LANG_C_plus_plus_11: > > case DW_LANG_C_plus_plus_14: > > + case DW_LANG_C_plus_plus_20: > > + case DW_LANG_C_plus_plus_23: > > return DMGL_GNU_V3; > > > > Should we add `DW_LANG_C_plus_plus_17`, too? > > You re absolutely right, I forgot to add it. > Thank you! --000000000000750fb50628d8370e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Dec 9, = 2024 at 11:51=E2=80=AFAM Rohr, Stephan <stephan.rohr@intel.com> wrote:
Hi Alexandra,

just a small nit.

Stephan

> -----Original Message-----
> From: Alexandra H=C3=A1jkov=C3=A1 <ahajkova@redhat.com>
> Sent: Monday, 9 December 2024 11:21
> To: gd= b-patches@sourceware.org
> Cc: ahajkova@= redhat.com
> Subject: [PATCH 2/2] mangle_style: Add new DWARF5 constants
>
> Update bfd/dwarf2.c with the new DWARF5 language codes to
> make it possible to return the mangling style for the new
> language codes for Ada 2005 and 20015, Fortran 18 and 23,
> C++ 20 and 23, C 17 and 23 and Assembly.
> ---
>=C2=A0 bfd/dwarf2.c | 9 +++++++++
>=C2=A0 1 file changed, 9 insertions(+)
>
> diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> index 151ed0237ca..ec298764c8a 100644
> --- a/bfd/dwarf2.c
> +++ b/bfd/dwarf2.c
> @@ -1725,12 +1725,16 @@ mangle_style (int lang)
>=C2=A0 =C2=A0 =C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_Ada83:
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_Ada95:
> +=C2=A0 =C2=A0 case DW_LANG_Ada2005:
> +=C2=A0 =C2=A0 case DW_LANG_Ada2012:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 return DMGL_GNAT;
>
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_C_plus_plus:
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_C_plus_plus_03:
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_C_plus_plus_11:
>=C2=A0 =C2=A0 =C2=A0 case DW_LANG_C_plus_plus_14:
> +=C2=A0 =C2=A0 case DW_LANG_C_plus_plus_20:
> +=C2=A0 =C2=A0 case DW_LANG_C_plus_plus_23:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 return DMGL_GNU_V3;
>

Should we add `DW_LANG_C_plus_plus_17`, too?

You re absolutely right, I forgot to add it.

Thank you!
--000000000000750fb50628d8370e--