[PATCH]Fix aarch64 native build issue caused by use of LONGEST

[PATCH]Fix aarch64 native build issue caused by use of LONGEST

[Bin.Cheng]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi,
Recent gdb code refactor changes LONGEST from a macro to a typedef,
thus the use of it in aarch64-linux-nat.c is no longer valid.

This patch fixes the build failure which is obvious.  Is it OK?

Thanks,
bin

2014-08-21  Bin Cheng  <bin.cheng@arm.com>

* aarch64-linux-nat.c (dr_changed_t): Change the type from
unsigned LONGEST to ULONGEST.

[-- Attachment #2: aarch64-linux-nat.txt --]
[-- Type: text/plain, Size: 476 bytes --]

diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 4ae789b..1184197 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -144,7 +144,7 @@ static int debug_hw_points;
    ptrace calls to the kernel, i.e. avoid asking the kernel to write
    to the debug registers with unchanged values.  */
 
-typedef unsigned LONGEST dr_changed_t;
+typedef ULONGEST dr_changed_t;
 
 /* Set each of the lower M bits of X to 1; assert X is wide enough.  */
 

Re: [PATCH]Fix aarch64 native build issue caused by use of LONGEST

[Will Newton]

On 21 August 2014 09:32, Bin.Cheng <amker.cheng@gmail.com> wrote:
> Hi,
> Recent gdb code refactor changes LONGEST from a macro to a typedef,
> thus the use of it in aarch64-linux-nat.c is no longer valid.
>
> This patch fixes the build failure which is obvious.  Is it OK?
>
> Thanks,
> bin
>
> 2014-08-21  Bin Cheng  <bin.cheng@arm.com>
>
> * aarch64-linux-nat.c (dr_changed_t): Change the type from
> unsigned LONGEST to ULONGEST.

I pushed this as obvious given that Marcus is not around.

-- 
Will Newton
Toolchain Working Group, Linaro

Re: [PATCH]Fix aarch64 native build issue caused by use of LONGEST

[Gary Benson]

Will Newton wrote:
> On 21 August 2014 09:32, Bin.Cheng <amker.cheng@gmail.com> wrote:
> > Recent gdb code refactor changes LONGEST from a macro to a typedef,
> > thus the use of it in aarch64-linux-nat.c is no longer valid.
> >
> > This patch fixes the build failure which is obvious.  Is it OK?
> >
> > 2014-08-21  Bin Cheng  <bin.cheng@arm.com>
> >
> > * aarch64-linux-nat.c (dr_changed_t): Change the type from
> > unsigned LONGEST to ULONGEST.
> 
> I pushed this as obvious given that Marcus is not around.

Bin, Will, thanks for fixing this.

Cheers,
Gary

-- 
http://gbenson.net/