From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: Tamar Christina <Tamar.Christina@arm.com>,
"keiths@redhat.com" <keiths@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [RFA 2/3] PR gdb/20653 - small cleanup in string_to_explicit_location
Date: Mon, 24 Oct 2016 11:10:00 -0000 [thread overview]
Message-ID: <CAH=s-PPsiJARs7Bw89s9PiNOoaVqSh25UMH0KkEVSF6UaEKsAA@mail.gmail.com> (raw)
In-Reply-To: <CAH=s-PNRhbe9pypkm4=VwCo_Y+CNwcW1PCjC=vBeb2Us7tUHWQ@mail.gmail.com>
On Mon, Oct 17, 2016 at 10:04 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Oct 6, 2016 at 4:15 PM, Tom Tromey <tom@tromey.com> wrote:
>>>>>>> "Tamar" == Tamar Christina <Tamar.Christina@arm.com> writes:
>>
>> Tamar> Any progress on getting this patch committed?
>> Tamar> This issue is currently breaking our nightlies.
>>
>> I pushed the patch yesterday.
>
> Hi Tom,
> Could you push this patch in to 7.12 branch too? Otherwise, we have a
> build failure on gdb 7.12 branch with gcc trunk,
>
> ../../binutils-gdb/gdb/location.c: In function ‘event_location*
> string_to_explicit_location(const char**, const language_defn*, int)’:
> ../../binutils-gdb/gdb/location.c:527:19: error: ISO C++ forbids
> comparison between pointer and integer [-fpermissive]
> || *argp == '\0'
> ^~~~
> make[2]: *** [location.o] Error 1
>
I pushed this commit to 7.12 branch, and update wiki page
https://www.sourceware.org/gdb/wiki/GDB_7.12_Release
--
Yao (齐尧)
next prev parent reply other threads:[~2016-10-24 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR0801MB2031F8BBE482E30DC339C2E1FFC70@VI1PR0801MB2031.eurprd08.prod.outlook.com>
2016-10-06 9:10 ` Tamar Christina
2016-10-06 15:36 ` Tom Tromey
2016-10-06 15:42 ` Tamar Christina
[not found] ` <CAH=s-PNRhbe9pypkm4=VwCo_Y+CNwcW1PCjC=vBeb2Us7tUHWQ@mail.gmail.com>
2016-10-24 11:10 ` Yao Qi [this message]
2016-10-03 21:54 [RFA 0/3] Fix various bugs found by static analysis Tom Tromey
2016-10-03 21:54 ` [RFA 2/3] PR gdb/20653 - small cleanup in string_to_explicit_location Tom Tromey
2016-10-03 22:27 ` Keith Seitz
2016-10-04 10:50 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PPsiJARs7Bw89s9PiNOoaVqSh25UMH0KkEVSF6UaEKsAA@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=Tamar.Christina@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=nd@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox