From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31791 invoked by alias); 24 Oct 2016 11:10:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31691 invoked by uid 89); 24 Oct 2016 11:10:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: mail-qk0-f196.google.com Received: from mail-qk0-f196.google.com (HELO mail-qk0-f196.google.com) (209.85.220.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Oct 2016 11:10:09 +0000 Received: by mail-qk0-f196.google.com with SMTP id z190so12856411qkc.3 for ; Mon, 24 Oct 2016 04:10:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5XpIT+3Af9Gn1qHriwgNdfyRyeUbd29PExbgeMroEEA=; b=BfGKWGko4vOg19U0Hp3tR18oOk7dhiJNStQcnle2d3b7rxlnZILxFnmGkxKM44mKGl 8xoYUrCANbjyAy8Y7IciGW687xeCcx41f/Wg+AWYvy+XTQq71K1QRCBIIOTgASvGrdph JLjzVJphyoNRJQ3kh0a13woU+QDrBzBubTO+crF/0Bor3eqhGLDvEobsY5a0aqOuLzXE uBYHKAbeJzygkW+C94XrEk3Aju3PxHIoBMBOa3aeXABMRge6NLkVeU3k9hEMRfu/NalM i8wgqP+xHWkPp5vOiYb4OUZSVoKlK3VFzmOpssaErPZjTDUseqWYl64Clg0WbNFvJwrr jeMw== X-Gm-Message-State: ABUngve8AZ5JG0z2Js0+il0vwyZtwgKzqudpwteV0DkrKf5/YhcObYRHC9TlQwa8CauZRkm7SY42sjeF6VEbjA== X-Received: by 10.55.26.156 with SMTP id l28mr10849896qkh.164.1477307407184; Mon, 24 Oct 2016 04:10:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.149.168 with HTTP; Mon, 24 Oct 2016 04:10:06 -0700 (PDT) In-Reply-To: References: <87mvihecf9.fsf@tromey.com> From: Yao Qi Date: Mon, 24 Oct 2016 11:10:00 -0000 Message-ID: Subject: Re: [RFA 2/3] PR gdb/20653 - small cleanup in string_to_explicit_location To: Tom Tromey Cc: Tamar Christina , "keiths@redhat.com" , "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00659.txt.bz2 On Mon, Oct 17, 2016 at 10:04 AM, Yao Qi wrote: > On Thu, Oct 6, 2016 at 4:15 PM, Tom Tromey wrote: >>>>>>> "Tamar" =3D=3D Tamar Christina writes: >> >> Tamar> Any progress on getting this patch committed? >> Tamar> This issue is currently breaking our nightlies. >> >> I pushed the patch yesterday. > > Hi Tom, > Could you push this patch in to 7.12 branch too? Otherwise, we have a > build failure on gdb 7.12 branch with gcc trunk, > > ../../binutils-gdb/gdb/location.c: In function =E2=80=98event_location* > string_to_explicit_location(const char**, const language_defn*, int)=E2= =80=99: > ../../binutils-gdb/gdb/location.c:527:19: error: ISO C++ forbids > comparison between pointer and integer [-fpermissive] > || *argp =3D=3D '\0' > ^~~~ > make[2]: *** [location.o] Error 1 > I pushed this commit to 7.12 branch, and update wiki page https://www.sourceware.org/gdb/wiki/GDB_7.12_Release --=20 Yao (=E9=BD=90=E5=B0=A7)