From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] agent_expr_up: gdb::unique_ptr -> std::unique_ptr
Date: Wed, 09 Nov 2016 12:24:00 -0000 [thread overview]
Message-ID: <CAH=s-PPQNpyV1LkJbQ++CaO_+DhPK6U748rfs5MiaQaY8JRB=w@mail.gmail.com> (raw)
In-Reply-To: <1478652972-11094-1-git-send-email-palves@redhat.com>
On Wed, Nov 9, 2016 at 12:56 AM, Pedro Alves <palves@redhat.com> wrote:
>
> - /* Vector owns pointers. */
> - std::vector<agent_expr *> m_aexprs;
> + std::vector<std::unique_ptr<agent_expr>> m_aexprs;
Nit: s/std::unique_ptr<agent_expr>/agent_expr_up/ ?
The patch is good to me.
[Pretend having some C++ 11 knowledge after reading some pages
in "C++ Primer, fifth edition" for 20 minutes]
--
Yao (齐尧)
next prev parent reply other threads:[~2016-11-09 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 0:56 Pedro Alves
2016-11-09 12:24 ` Yao Qi [this message]
2016-11-09 15:04 ` Pedro Alves
2016-11-09 23:03 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PPQNpyV1LkJbQ++CaO_+DhPK6U748rfs5MiaQaY8JRB=w@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox