From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44997 invoked by alias); 9 Nov 2016 12:24:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44929 invoked by uid 89); 9 Nov 2016 12:24:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=primer X-HELO: mail-qt0-f173.google.com Received: from mail-qt0-f173.google.com (HELO mail-qt0-f173.google.com) (209.85.216.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 12:24:25 +0000 Received: by mail-qt0-f173.google.com with SMTP id c47so125388083qtc.2 for ; Wed, 09 Nov 2016 04:24:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RACpw2APRpXOXGTInoz4fAk1LdnIx3coBzp+aj0KI94=; b=dKX6Hcny8iNx+/tI+l8Tb/pO+RVlVtNQMO/xiBqLOV0f7Rvn99WjRppzgeJmI7e+T+ gLS7ZxsIO2IFdeyoxmI6DOB8FeDoYrFDhkYL51/Wio1g4qAzBEDALyf1ecy9tT6IPSOF C57qZh6uGCBCwlrptBUfJXfjUTcim+2tKUuOvtfZNvt+ZQ0SNrvJWVAQFd+dsFrsuJGp oRtyOyp77QxVRrjst7NL5e6//NgaB2PBkg9UuhjUntfPyC74o6mJod/Jh/5UGb5fp7XT H05Gql5yfyNd5Evtlw3Vo8zi+YapQjM09gYpA6bV/h8ljz81UTJ1C3q9kp9sX75EisX1 1JXQ== X-Gm-Message-State: ABUngveEjvuDxL7f/1mPgoCPgF0h69M3wN5oVxiWKgvgRM1UQGo89x0WpVHkilr9icma8wW5cXR9JnTF6SCtXA== X-Received: by 10.237.53.119 with SMTP id b52mr19271333qte.74.1478694264249; Wed, 09 Nov 2016 04:24:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.149.55 with HTTP; Wed, 9 Nov 2016 04:24:23 -0800 (PST) In-Reply-To: <1478652972-11094-1-git-send-email-palves@redhat.com> References: <1478652972-11094-1-git-send-email-palves@redhat.com> From: Yao Qi Date: Wed, 09 Nov 2016 12:24:00 -0000 Message-ID: Subject: Re: [PATCH] agent_expr_up: gdb::unique_ptr -> std::unique_ptr To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00211.txt.bz2 On Wed, Nov 9, 2016 at 12:56 AM, Pedro Alves wrote: > > - /* Vector owns pointers. */ > - std::vector m_aexprs; > + std::vector> m_aexprs; Nit: s/std::unique_ptr/agent_expr_up/ ? The patch is good to me. [Pretend having some C++ 11 knowledge after reading some pages in "C++ Primer, fifth edition" for 20 minutes] --=20 Yao (=E9=BD=90=E5=B0=A7)