From: Yao Qi <qiyaoltc@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFA: Fix assertion on replace_types()
Date: Mon, 13 Jun 2016 10:21:00 -0000 [thread overview]
Message-ID: <CAH=s-POZf1uzE-=Gup=9DFfk5wpY=-JTRbrR6gpizpuVz2BDGg@mail.gmail.com> (raw)
In-Reply-To: <87eg812zps.fsf@redhat.com>
On Mon, Jun 13, 2016 at 10:41 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi Guys,
>
> Compiling GDB with gcc version 6.1.1 from the about to be released
> Fedora 24 produces a warning/error about a redundant comparison in
> gdbtypes.c:replace_types(). The fix appears obvious to me, but since
> I am not a regular contributor, I thought that I had better check here
> first.
>
> OK to apply ?
Yes, it is OK. The comments say two types should be in the same objfile,
so your fix is right to me.
--
Yao (齐尧)
prev parent reply other threads:[~2016-06-13 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:41 Nick Clifton
2016-06-13 10:21 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-POZf1uzE-=Gup=9DFfk5wpY=-JTRbrR6gpizpuVz2BDGg@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox