From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84697 invoked by alias); 13 Jun 2016 10:21:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84682 invoked by uid 89); 13 Jun 2016 10:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.218.41, H*RU:209.85.218.41 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 13 Jun 2016 10:21:03 +0000 Received: by mail-oi0-f41.google.com with SMTP id p204so200485287oih.3 for ; Mon, 13 Jun 2016 03:21:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nssViXPFqQ3GWKYwsuRmsW1PKtVsGHvvEBQoWOXV2zk=; b=EZ9SJnoWBdf5Ta0+ghYBJe8y6FgeUKbYzSr27XiDddWV3tvBd+l/LHwb5P+kLQXTmO cYx8ii/XRdBefzWbERzQOeF3piLD3JRTR1XBgYUBqW0HfHePksx+AiB4Gs+Wh5MihlIS wWlDPSiP5YGNe6M6In/tb/a5PVX/yhGAtBZIxoHT+0JTa8Q3Owp1TvykqlD4gOc6bnHy X/VbyBakM0Q64teV8i3eVRf0/JO8ubnR2z66PnjUpKEfgA3bjOPZPc89SuYxFXr8f9LK ZRfncKU2yjY5S/Qn1/yZfYD5DkWJtCHbaBp5SxLtZoXeUrW5E/A+H3ONyU1lGT5a15SL Tw5w== X-Gm-Message-State: ALyK8tJNcAvVPqyDYYjv+r7BaDOuP1m2CLSjY1SZHMEGs/4wOI83bDO7CCoacONd9mJfExjLE/CN/E85HYKjDw== X-Received: by 10.202.181.131 with SMTP id e125mr5706938oif.12.1465813261776; Mon, 13 Jun 2016 03:21:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.68.4 with HTTP; Mon, 13 Jun 2016 03:21:01 -0700 (PDT) In-Reply-To: <87eg812zps.fsf@redhat.com> References: <87eg812zps.fsf@redhat.com> From: Yao Qi Date: Mon, 13 Jun 2016 10:21:00 -0000 Message-ID: Subject: Re: RFA: Fix assertion on replace_types() To: Nick Clifton Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00218.txt.bz2 On Mon, Jun 13, 2016 at 10:41 AM, Nick Clifton wrote: > Hi Guys, > > Compiling GDB with gcc version 6.1.1 from the about to be released > Fedora 24 produces a warning/error about a redundant comparison in > gdbtypes.c:replace_types(). The fix appears obvious to me, but since > I am not a regular contributor, I thought that I had better check here > first. > > OK to apply ? Yes, it is OK. The comments say two types should be in the same objfile, so your fix is right to me. --=20 Yao (=E9=BD=90=E5=B0=A7)