From: Yao Qi <qiyaoltc@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind
Date: Mon, 10 Oct 2016 10:17:00 -0000 [thread overview]
Message-ID: <CAH=s-PO0R2UWAro8_iXpove8Byv5eGy3wE9WM=iR1HgO+ePr_g@mail.gmail.com> (raw)
In-Reply-To: <1472655965-12212-1-git-send-email-yao.qi@linaro.org>
On Wed, Aug 31, 2016 at 4:05 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> This patch series is to split gdbarch method brekapoint_from_pc to
> methods breakpoint_kind_from_pc and sw_breakpoint_from_kind. After
> these changes, new gdbarch methods breakpoint_kind_from_pc and
> sw_breakpoint_from_kind are more preferred than brekapoint_from_pc.
>
> In this patch https://sourceware.org/ml/gdb-patches/2016-05/msg00201.html,
> I wanted to remove a global variable arm_override_mode, and the
> discussion leads to a design here
> https://sourceware.org/ml/gdb-patches/2016-07/msg00211.html In short,
> we reuse bp_target_info.placed_size as the "kind" of a breakpoint,
> which can be got by gdbarch breakpoint_kind_from_pc or
> breakpoint_kind_from_current_state.
>
> I choose a way that I can change the code incrementally, and make the
> review easier. Patch #1, #2, #5, and #8 are obvious, IMO. Patch #7
> and #12 do the major work, and the rest are code refactor.
>
> Regression tested on arm-linux and x86_64-linux. Tests on other
> architectures are welcome!
>
I've pushed patches 1#, #2, and #5 in, because they are obvious.
Update patch 7 to cover arc.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-10-10 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:06 Yao Qi
2016-08-31 15:06 ` [PATCH 10/13] Remove gdbarch_remote_breakpoint_from_pc Yao Qi
2016-10-27 14:55 ` Pedro Alves
2016-08-31 15:06 ` [PATCH 04/13] GDBARCH_BREAKPOINT_MANIPULATION and SET_GDBARCH_BREAKPOINT_MANIPULATION Yao Qi
2016-08-31 15:06 ` [PATCH 09/13] Rename placed_size to kind Yao Qi
2016-08-31 15:06 ` [PATCH 01/13] Remove v850_dbtrap_breakpoint_from_pc Yao Qi
2016-08-31 15:06 ` [PATCH 12/13] Determine the kind of single step breakpoint Yao Qi
2016-10-27 14:55 ` Pedro Alves
2016-08-31 15:06 ` [PATCH 03/13] gdbarch_breakpoint_from_pc doesn't return NULL Yao Qi
2016-09-28 15:23 ` Michael Eager
2016-08-31 15:06 ` [PATCH 11/13] Add default_breakpoint_from_pc Yao Qi
2016-08-31 15:06 ` [PATCH 07/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind Yao Qi
2016-10-10 10:05 ` Yao Qi
2016-10-27 14:55 ` Pedro Alves
2016-10-28 19:44 ` Maciej W. Rozycki
2016-08-31 15:06 ` [PATCH 13/13] Remove arm_override_mode Yao Qi
2016-10-27 14:56 ` Pedro Alves
2016-08-31 15:06 ` [PATCH 08/13] New gdbarch methods breakpoint_kind_from_pc and sw_breakpoint_from_kind Yao Qi
2016-08-31 15:06 ` [PATCH 06/13] Add enum for mips breakpoint kinds Yao Qi
2016-10-27 14:54 ` Pedro Alves
2016-10-28 19:39 ` Maciej W. Rozycki
2016-08-31 15:06 ` [PATCH 05/13] Share enum arm_breakpoint_kinds Yao Qi
2016-08-31 15:06 ` [PATCH 02/13] Rename 'arch' by 'gdbarch' in m32c_gdbarch_init Yao Qi
2016-10-10 10:17 ` Yao Qi [this message]
2016-10-26 15:43 ` [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind Yao Qi
2016-10-27 14:58 ` Pedro Alves
2016-10-27 15:41 ` Yao Qi
2016-10-27 17:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PO0R2UWAro8_iXpove8Byv5eGy3wE9WM=iR1HgO+ePr_g@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox