From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18839 invoked by alias); 10 Oct 2016 10:17:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18826 invoked by uid 89); 10 Oct 2016 10:17:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=welcome! X-HELO: mail-oi0-f65.google.com Received: from mail-oi0-f65.google.com (HELO mail-oi0-f65.google.com) (209.85.218.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Oct 2016 10:17:11 +0000 Received: by mail-oi0-f65.google.com with SMTP id e12so916648oib.3 for ; Mon, 10 Oct 2016 03:17:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=Xjbnvu9a0+NF3YvmwJMdKOGc6/ltBeLl/1g0HcAmHu0=; b=hLlVnmIN9l3mg+CjIQzsxVxXwJtswDRLcBVQkx1fiZjhN+3bWdS6NhUi4OgGLiGB7x qvOfhgmkd6s/Ek28CNPWvJi+n5Kictj6Iv/Ux4ztr/mV/qbUYjuQfVuFdrXH4uFDJWpI +K8e7+9EBnTajYyLRKtXNjnRPZnlNLP2CfxmDvwDOz/WysVCHqJEUld3vYS0kMFHWAXQ piXCY+ITSm9OxP5z5HDVl6Fco+wGD8NvVPxiNc05v56IgETnnoXtqPEdBl39iYMQS8j0 EGagcVj1AuM+CuyYFkYB/64g1OLP84QnlpqA7ka6a3U1/HczBNl8iEntM/Zi0nd9pC08 ReAQ== X-Gm-Message-State: AA6/9RngcONrJlzy/+K4h+N7+1Qj+pCMIgg9uP4bHysfslhV+FOaXkzfGNzJRafwCZw9kJK79Iz6c+wwsyWmuA== X-Received: by 10.157.11.92 with SMTP id p28mr16658427otd.109.1476094629686; Mon, 10 Oct 2016 03:17:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.221.3 with HTTP; Mon, 10 Oct 2016 03:17:09 -0700 (PDT) In-Reply-To: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Mon, 10 Oct 2016 10:17:00 -0000 Message-ID: Subject: Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind To: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00213.txt.bz2 On Wed, Aug 31, 2016 at 4:05 PM, Yao Qi wrote: > This patch series is to split gdbarch method brekapoint_from_pc to > methods breakpoint_kind_from_pc and sw_breakpoint_from_kind. After > these changes, new gdbarch methods breakpoint_kind_from_pc and > sw_breakpoint_from_kind are more preferred than brekapoint_from_pc. > > In this patch https://sourceware.org/ml/gdb-patches/2016-05/msg00201.html, > I wanted to remove a global variable arm_override_mode, and the > discussion leads to a design here > https://sourceware.org/ml/gdb-patches/2016-07/msg00211.html In short, > we reuse bp_target_info.placed_size as the "kind" of a breakpoint, > which can be got by gdbarch breakpoint_kind_from_pc or > breakpoint_kind_from_current_state. > > I choose a way that I can change the code incrementally, and make the > review easier. Patch #1, #2, #5, and #8 are obvious, IMO. Patch #7 > and #12 do the major work, and the rest are code refactor. > > Regression tested on arm-linux and x86_64-linux. Tests on other > architectures are welcome! > I've pushed patches 1#, #2, and #5 in, because they are obvious. Update patch 7 to cover arc. --=20 Yao (=E9=BD=90=E5=B0=A7)