From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile}
Date: Tue, 23 Aug 2016 13:28:00 -0000 [thread overview]
Message-ID: <CAH=s-PNuaQAeWcJ=D8ACUd+z3eBy9ErS4woj5y=Fkyg8qaruFQ@mail.gmail.com> (raw)
In-Reply-To: <ba1f883876e7703b732d64d522d61bde@simark.ca>
On Mon, Aug 22, 2016 at 7:12 PM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> On 2016-08-22 10:57, Yao Qi wrote:
>>
>> --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp
>> +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp
>> @@ -44,7 +44,7 @@ proc do_test {nonstop} {
>>
>> gdb_test "set non-stop $nonstop"
>>
>> - set res [gdbserver_spawn ${binfile}]
>> + set res [gdbserver_spawn ""]
>
>
> You could make gdbserver_spawn have a default empty argument, so you don't
> have to keep the empty string here.
Yes, this can be a separate fix. I don't have cycles to fix it
recently, so patch
is welcome :)
--
Yao (齐尧)
prev parent reply other threads:[~2016-08-23 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 14:57 Yao Qi
2016-08-22 17:55 ` Pedro Alves
2016-08-23 13:25 ` Yao Qi
2016-08-22 18:12 ` Simon Marchi
2016-08-23 13:28 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNuaQAeWcJ=D8ACUd+z3eBy9ErS4woj5y=Fkyg8qaruFQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox