From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75411 invoked by alias); 23 Aug 2016 13:28:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74945 invoked by uid 89); 23 Aug 2016 13:28:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Simon, Hx-languages-length:709, U*simon.marchi, simonmarchipolymtlca X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Aug 2016 13:28:38 +0000 Received: by mail-oi0-f53.google.com with SMTP id f189so195396190oig.3 for ; Tue, 23 Aug 2016 06:28:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=buo5torP8ATFKtRXaVr/Arit+/9KdjsrmJO0MF/AmAY=; b=cVEbQd37zlP3AXurPcImsICTiis0ZQUz0y7coO4ezSKlumuQ41FWqnbByVOvvgXmRY R5/Kd/NOXaqMVn6tP556pvYa8k1XLDFHpK+qEPJM9/PksduiJgMkvgea6jzIfCyiC5VP L7VsP+O8ywm5WueT8IiIi+IPgJ0iJQ4UrTWDyALHAtI6m+vFxcsuyhGd4vwMQNqklOrc BqqNtvMo6wH0n7eW8OCgeyHFJgrYsgNfeth7xgUJ/uRHjyEnAldxvI9o9F+5aNKki05L z9uiUJrp6iqfZ+TLKNAgYebcxNUvaqwPwzPI6QMeGpkjbp8PvpK+0gpyEPXhFjDUMp1F FOIw== X-Gm-Message-State: AEkoouv4VB3D4ZWjI1HLxe1eTswGBH7Vlownse3A6beJKTT+2b8EqD/Sw7Riw5jcnV8Nmbt64jJ9jHkQwlgpAg== X-Received: by 10.202.217.70 with SMTP id q67mr16406002oig.86.1471958916685; Tue, 23 Aug 2016 06:28:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.207.201 with HTTP; Tue, 23 Aug 2016 06:28:36 -0700 (PDT) In-Reply-To: References: <1471877845-1158-1-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Tue, 23 Aug 2016 13:28:00 -0000 Message-ID: Subject: Re: [PATCH] gdbserver_spawn "" rather than gdbserver_spawn ${binfile} To: Simon Marchi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00226.txt.bz2 On Mon, Aug 22, 2016 at 7:12 PM, Simon Marchi wro= te: > On 2016-08-22 10:57, Yao Qi wrote: >> >> --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp >> +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp >> @@ -44,7 +44,7 @@ proc do_test {nonstop} { >> >> gdb_test "set non-stop $nonstop" >> >> - set res [gdbserver_spawn ${binfile}] >> + set res [gdbserver_spawn ""] > > > You could make gdbserver_spawn have a default empty argument, so you don't > have to keep the empty string here. Yes, this can be a separate fix. I don't have cycles to fix it recently, so patch is welcome :) --=20 Yao (=E9=BD=90=E5=B0=A7)