From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA 2/3] Add missing ATTRIBUTE_NORETURNs
Date: Wed, 28 Sep 2016 17:41:00 -0000 [thread overview]
Message-ID: <CAH=s-PNTcdPB1zqVCP99_Rx=_Ao6JjpAJpCK9NoOn9CagaznZA@mail.gmail.com> (raw)
In-Reply-To: <871t04cap5.fsf@tromey.com>
On Wed, Sep 28, 2016 at 4:20 PM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
>
>>> -extern void throw_max_completions_reached_error (void);
>>> +extern void throw_max_completions_reached_error (void)
>>> + ATTRIBUTE_NORETURN;
>
> Yao> Don't we need to also add ATTRIBUTE_NORETURN to the definition of
> Yao> throw_max_completions_reached_error?
>
> No, it's sufficient to have an attribute on a prototype, if the
> prototype is in scope when the definition is seen. This seems to be the
> normal approach in gdb, e.g., see error_no_arg.
>
Er... right. Patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-09-28 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:16 [RFA 0/3] Fix some -Wimplicit-fallthrough warnings Tom Tromey
2016-09-27 18:16 ` [RFA 1/3] Fix "fall through" comments Tom Tromey
2016-09-27 21:48 ` Yao Qi
2016-09-27 21:53 ` Tom Tromey
2016-09-28 21:51 ` Yao Qi
2016-09-28 21:58 ` Tom Tromey
2016-09-30 21:09 ` Yao Qi
2016-09-27 18:16 ` [RFA 2/3] Add missing ATTRIBUTE_NORETURNs Tom Tromey
2016-09-28 7:28 ` Yao Qi
2016-09-28 17:40 ` Tom Tromey
2016-09-28 17:41 ` Yao Qi [this message]
2016-09-27 18:52 ` [RFA 3/3] Fix "obvious" fall-through warnings Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNTcdPB1zqVCP99_Rx=_Ao6JjpAJpCK9NoOn9CagaznZA@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox