From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62221 invoked by alias); 28 Sep 2016 17:40:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62171 invoked by uid 89); 28 Sep 2016 17:40:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=qiyaoltcgmailcom, qiyaoltc@gmail.com, U*qiyaoltc, sk:qiyaolt X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Sep 2016 17:39:50 +0000 Received: by mail-oi0-f67.google.com with SMTP id a62so3460172oib.1 for ; Wed, 28 Sep 2016 10:39:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4SoM1oKZ2E1BBp49l05z71XtMXV96wXM4JAryW04LOE=; b=id3WHcrhE1/pctev6xCX0OyqHiM1oGPr7ICDFteVVeO3F2HJGeuJRxtNhEEDAmKkZr ZmOxRnJOHuXWYHEuVI8takUqG86h1ACSbjvM+EnwaNPSLnme3ItsP2Th3eYxnIWD15hu UlWqnDSrLOnypIlcskldqQGeSjTs7NKPhA1jothMybkQ30JYIR4jvnujblTDcYuEB7vD xEYvMP7lM+QhrMVwOVIJey/I+IqT69LFl0ECirRUXQjpj4SQSlTDtk1LAJnzsQJ94j3y SXD5xoEawh1brLR+1oC0Yw5OpMhF0v8F2iuYKN1vDAEckRPUBdHWCuBF0bJb6nbC5DZc xrbg== X-Gm-Message-State: AE9vXwNFJLZZ0Y/YU4EBgsqihNWbK+RMbUIVgVznhoMEE2wD39ge1PaiDqZ0PC3yET9IjQxUFgYJp571kicUJA== X-Received: by 10.202.90.213 with SMTP id o204mr41582483oib.186.1475084388802; Wed, 28 Sep 2016 10:39:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.237.20 with HTTP; Wed, 28 Sep 2016 10:39:48 -0700 (PDT) In-Reply-To: <871t04cap5.fsf@tromey.com> References: <1475000192-8789-1-git-send-email-tom@tromey.com> <1475000192-8789-3-git-send-email-tom@tromey.com> <871t04cap5.fsf@tromey.com> From: Yao Qi Date: Wed, 28 Sep 2016 17:41:00 -0000 Message-ID: Subject: Re: [RFA 2/3] Add missing ATTRIBUTE_NORETURNs To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00401.txt.bz2 On Wed, Sep 28, 2016 at 4:20 PM, Tom Tromey wrote: >>>>>> "Yao" =3D=3D Yao Qi writes: > >>> -extern void throw_max_completions_reached_error (void); >>> +extern void throw_max_completions_reached_error (void) >>> + ATTRIBUTE_NORETURN; > > Yao> Don't we need to also add ATTRIBUTE_NORETURN to the definition of > Yao> throw_max_completions_reached_error? > > No, it's sufficient to have an attribute on a prototype, if the > prototype is in scope when the definition is seen. This seems to be the > normal approach in gdb, e.g., see error_no_arg. > Er... right. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)