From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 1/6] : Commonise various target-descriptions.c functions
Date: Fri, 19 Jan 2018 23:05:00 -0000 [thread overview]
Message-ID: <CAH=s-PM+xaphXX4CfsbQXuLdpU5vywnMpYfRKVkUYKk4Z-S62g@mail.gmail.com> (raw)
In-Reply-To: <CFD4D062-238A-456A-97B1-892FF8D32DF1@arm.com>
On Tue, Jan 16, 2018 at 9:50 AM, Alan Hayward <Alan.Hayward@arm.com> wrote:
> This patch simply moves functionality from target-descriptions.c
> to the common files arch/tdesc.c and arch/tdesc.h.
> No functionality is changed.
> This will allow usage by gdbserver.
> The "#ifndef GDBSERVER" around the functions in arch/tdesc.h will be removed
> in the next patch.
>
It is not right to move everything to arch/ and remove unused bits. GDB now
is able to visit different tdesc_element, you want to do the same in
GDBserver, and share the code in arch/. However, tdesc stuff in GDB and
GDBserver are quite different, so the 1st step, IMO, is to make GDBserver
more similar to GDB. You can change each tdesc-related struct in each
patch, and refactor GDBserver bits. Then, only move *needed* structures
to arch/, and move one structure in one patch each, if possible.
--
Yao (齐尧)
next prev parent reply other threads:[~2018-01-19 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:52 [PATCH 0/6] : Remove XML files from gdbserver Alan Hayward
2018-01-16 9:51 ` [PATCH 1/6] : Commonise various target-descriptions.c functions Alan Hayward
2018-01-16 14:18 ` Alan Hayward
2018-01-19 23:05 ` Yao Qi [this message]
2018-01-22 14:06 ` Alan Hayward
2018-01-22 15:47 ` Yao Qi
2018-01-16 9:52 ` [PATCH 2/6]: gdbserver use common tdesc functions Alan Hayward
2018-01-16 9:53 ` [PATCH 3/6] : Update dat files with arch and osabi Alan Hayward
2018-01-19 22:01 ` Yao Qi
2018-01-22 13:22 ` Alan Hayward
2018-01-22 15:28 ` Yao Qi
2018-01-16 9:55 ` [PATCH 6/6]: Remove xml files from gdbserver Alan Hayward
2018-01-19 22:11 ` Yao Qi
2018-01-22 13:23 ` Alan Hayward
2018-01-22 14:52 ` Yao Qi
2018-01-16 9:55 ` [PATCH 5/6] : Remove xml file references from target descriptions Alan Hayward
2018-01-16 9:55 ` [PATCH 4/6]: Create xml " Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PM+xaphXX4CfsbQXuLdpU5vywnMpYfRKVkUYKk4Z-S62g@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox