From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61633 invoked by alias); 19 Jan 2018 23:05:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61620 invoked by uid 89); 19 Jan 2018 23:05:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-Smtp-Source:sk:AH8x224, visit X-HELO: mail-qt0-f196.google.com Received: from mail-qt0-f196.google.com (HELO mail-qt0-f196.google.com) (209.85.216.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 23:05:51 +0000 Received: by mail-qt0-f196.google.com with SMTP id x27so7743982qtm.12 for ; Fri, 19 Jan 2018 15:05:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=keZNHTaOCXzveNXLkO+dcWD6Ym8FYI3jcsrQRHSZB+w=; b=b5H8huV//zuDgX11d7U4JTy7bDR/lXqO1bFdkI4KwEtxFXZLAOdvOiD8Hy3M+NpKuN WE6uDqJJt+kxGsT/4uAXfrpgPgAVCCKGO1XDFn4wR/NCWlfbctb8bQ0fcOOQOLe0n3fA 4/gKIgP1ngihEUeBbhRBGnBU43Wvcz1HMHfzv1EpXOZRlyZBwRFKH/xNKWy0m4VIiU0N OjV/ZNJWIl0FSpqz3oAauq1DzbzncaIV+y7Ys+f8kT7TLEOPc/IjWxBIX33KGChkiXOv rq0VoTmWrjRXZbg/A+B1Hx19PpVr6Qr100yY0QLhi9PhXEUQTwI+yW7EeZMT9ncrH3Ms Bk7g== X-Gm-Message-State: AKwxytd69aZQOw3DAbplY8nBKRG85oQ0X56ZUHmqqC8VyZ14qjEUEayS 6RREx3vV03/2cBob9F/hcSq+W1FaBSq+h3IIMq8= X-Google-Smtp-Source: AH8x224mq1y7i6eC9896YSPaG8VlbDtUXUhn/1PI4w/Z1+AgeFYsLzwGGJHvUoZ1cBak1FzxGkNPst1S5mfPtIoDP4U= X-Received: by 10.55.88.68 with SMTP id m65mr124082qkb.186.1516403149768; Fri, 19 Jan 2018 15:05:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Fri, 19 Jan 2018 15:05:49 -0800 (PST) In-Reply-To: References: From: Yao Qi Date: Fri, 19 Jan 2018 23:05:00 -0000 Message-ID: Subject: Re: [PATCH 1/6] : Commonise various target-descriptions.c functions To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00420.txt.bz2 On Tue, Jan 16, 2018 at 9:50 AM, Alan Hayward wrote: > This patch simply moves functionality from target-descriptions.c > to the common files arch/tdesc.c and arch/tdesc.h. > No functionality is changed. > This will allow usage by gdbserver. > The "#ifndef GDBSERVER" around the functions in arch/tdesc.h will be remo= ved > in the next patch. > It is not right to move everything to arch/ and remove unused bits. GDB now is able to visit different tdesc_element, you want to do the same in GDBserver, and share the code in arch/. However, tdesc stuff in GDB and GDBserver are quite different, so the 1st step, IMO, is to make GDBserver more similar to GDB. You can change each tdesc-related struct in each patch, and refactor GDBserver bits. Then, only move *needed* structures to arch/, and move one structure in one patch each, if possible. --=20 Yao (=E9=BD=90=E5=B0=A7)