From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>, Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3
Date: Sat, 30 Aug 2014 13:48:00 -0000 [thread overview]
Message-ID: <CAGyQ6gzAZDjU=Rc4ifxV8X-54-MrGn-0ANL+TupqmEx=CzpZtw@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gwhHznkNj33gxk-du+VL=wRp1KUP-k1xZPTkndbnQAbjg@mail.gmail.com>
On Fri, Aug 15, 2014 at 6:16 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Aug 14, 2014 at 3:34 PM, Doug Evans <dje@google.com> wrote:
>> Siva Chandra writes:
>> > The attached patch fixes the "no space before parenthesis in Python"
>> > comment by Joel. The comment was for the changes in the test suite.
>> > Going by examples, I thought the test case code (but not the .exp
>> > files) did not require adherence to coding style.
>> >
>> > I also agree with Joel that this patch should also pushed to the 7.8 branch.
>> >
>> > ChangeLog:
>> > 2014-08-14 Siva Chandra Reddy <sivachandra@gmail.com>
>> >
>> > gdb/
>> >
>> > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the
>> > 'items' methods instead of 'iteritems' method on dictionaries.
>> >
>> > gdb/testsuite/
>> >
>> > * gdb.python/py-xmethods.py (A_getarrayind)
>> > (E_method_char_worker.__call__, E_method_int_worker.__call__):
>> > Use 'print' with function call syntax.
>> > (E_method_matcher.match): Fix tab vs space indentation mixup.
>>
>> LGTM
>
> Pushed 940df408121be31beed22ef7a5ad133cb1592726.
Missed asking: OK for 7.8 branch?
next prev parent reply other threads:[~2014-08-30 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 13:53 Siva Chandra
2014-08-14 22:35 ` Doug Evans
2014-08-16 1:16 ` Siva Chandra
2014-08-30 13:48 ` Siva Chandra [this message]
2014-09-01 6:30 ` Joel Brobecker
2014-09-02 13:23 ` Siva Chandra
2014-09-02 14:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gzAZDjU=Rc4ifxV8X-54-MrGn-0ANL+TupqmEx=CzpZtw@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox