From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13925 invoked by alias); 30 Aug 2014 13:48:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13908 invoked by uid 89); 30 Aug 2014 13:48:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f174.google.com Received: from mail-ob0-f174.google.com (HELO mail-ob0-f174.google.com) (209.85.214.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 30 Aug 2014 13:48:09 +0000 Received: by mail-ob0-f174.google.com with SMTP id uz6so2646330obc.5 for ; Sat, 30 Aug 2014 06:48:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6u9JpJ9F8w6108JWPeYXjkqGkkzqDHLM6eLSOc89rMM=; b=QKW+hurk2zv8yNQS4wYxCVVvgzAdb4b3lq+eC8rrNeSiweOmdyHSs6f4Zl5s1LGEro vUjaICca6dJTfaRGUz2qO/D7ZmelrS/c6lcC+oFvrHNyZQlmWD1NoO0pLckyMgKu5hbu Kw2ngtIQG2ZNH2uhMBlccWQdMGYxp8as0hNeZza96M8dy2sbw38HdcWTOu3LCkyONoYn 8aaCec0M34eOOY3vHrkD913BhiqjE7xQKwvOps50nAd+czMWeFFUy0Wj2Xj6d4MlkIxX xZwWEO6Ke1YcNUrlXGvGLRQ8/iSU/96ShPWuAZv684MNSnhajJf0clGxxMMQUzL9YIna PNEQ== X-Gm-Message-State: ALoCoQkCArqpSS2zBsCMApT3OnTHsaQwQoC6VavjEA875WAjt7FFNir40KH0DToKEPyNdUl/Pu1x MIME-Version: 1.0 X-Received: by 10.60.65.8 with SMTP id t8mr16769652oes.47.1409406487570; Sat, 30 Aug 2014 06:48:07 -0700 (PDT) Received: by 10.202.225.135 with HTTP; Sat, 30 Aug 2014 06:48:07 -0700 (PDT) In-Reply-To: References: <21485.14738.947462.758709@ruffy.mtv.corp.google.com> Date: Sat, 30 Aug 2014 13:48:00 -0000 Message-ID: Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3 From: Siva Chandra To: Doug Evans , Joel Brobecker Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00665.txt.bz2 On Fri, Aug 15, 2014 at 6:16 PM, Siva Chandra wrote: > On Thu, Aug 14, 2014 at 3:34 PM, Doug Evans wrote: >> Siva Chandra writes: >> > The attached patch fixes the "no space before parenthesis in Python" >> > comment by Joel. The comment was for the changes in the test suite. >> > Going by examples, I thought the test case code (but not the .exp >> > files) did not require adherence to coding style. >> > >> > I also agree with Joel that this patch should also pushed to the 7.8 branch. >> > >> > ChangeLog: >> > 2014-08-14 Siva Chandra Reddy >> > >> > gdb/ >> > >> > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the >> > 'items' methods instead of 'iteritems' method on dictionaries. >> > >> > gdb/testsuite/ >> > >> > * gdb.python/py-xmethods.py (A_getarrayind) >> > (E_method_char_worker.__call__, E_method_int_worker.__call__): >> > Use 'print' with function call syntax. >> > (E_method_matcher.match): Fix tab vs space indentation mixup. >> >> LGTM > > Pushed 940df408121be31beed22ef7a5ad133cb1592726. Missed asking: OK for 7.8 branch?