Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4] Make chained function calls in expressions work
Date: Mon, 03 Nov 2014 21:22:00 -0000	[thread overview]
Message-ID: <CAGyQ6gyqQYG4fFTaC+v-6ahBacXb6Q6hpOsO+9bsR_3D_f9AZA@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gzttH0kH5R7bBSTc0prDgE9ogCA-BXjDAaL2nM+S+cc=g@mail.gmail.com>

On Mon, Nov 3, 2014 at 11:55 AM, Siva Chandra <sivachandra@google.com> wrote:
>>>+/* Return true is T is a class or a union.  False otherwise.  */
>>>+
>>>+int
>>>+class_or_union_p (const struct type *t)
>>>+{
>>>+  return (TYPE_CODE (t) == TYPE_CODE_STRUCT
>>>+        || TYPE_CODE (t) == TYPE_CODE_UNION);
>>>+}
>>
>> I understand we need to do this for classes with member functions (so that
>> f().g() will work) -- do we really need it for classes without member
>> functions (or plain C structs)?
>
> We could have a struct like this in C++:
>
> struct Derived : public virtual Base
> {
>  ...
> };
>
> Do you mean we should have a language check before reserving space on the stack?

Sorry for revisiting but I thought I can be a bit more elaborate on
this. To complete the example, I am talking about a case like this:

struct Base
{
  int base;
};

struct Derived : public virtual Base
{
  int derived;
};

Derived does not have any methods, but will be returned in a hidden
param as it has a virtual base class. Even for simple structs like
this:

struct Simple
{
  int simple;
};

the return value could be a reference argument for a subsequent
inferior function and hence would still need to be have an address.


  reply	other threads:[~2014-11-03 21:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-25 14:24 Siva Chandra
2014-11-03 14:35 ` Siva Chandra
2014-11-03 14:43 ` Ulrich Weigand
2014-11-03 19:55   ` Siva Chandra
2014-11-03 21:22     ` Siva Chandra [this message]
2014-11-04 13:43       ` Ulrich Weigand
2014-11-04 15:08         ` Siva Chandra
2014-11-04 15:40           ` Ulrich Weigand
2014-11-04 13:38     ` Ulrich Weigand
2014-11-04 14:26       ` Siva Chandra
2014-11-04 14:59         ` Ulrich Weigand
2014-11-04 15:23           ` Siva Chandra
2014-11-04 15:40             ` Ulrich Weigand
2014-11-11 14:55               ` Siva Chandra
2014-11-11 15:00                 ` Siva Chandra
2014-11-11 15:21                   ` Ulrich Weigand
2014-11-11 17:05                     ` Siva Chandra
2014-11-12 16:08                     ` Doug Evans
2014-11-12 17:29                       ` Doug Evans
2014-11-13  3:00                       ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyQ6gyqQYG4fFTaC+v-6ahBacXb6Q6hpOsO+9bsR_3D_f9AZA@mail.gmail.com \
    --to=sivachandra@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox