From: Siva Chandra <sivachandra@google.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4] Make chained function calls in expressions work
Date: Tue, 04 Nov 2014 15:23:00 -0000 [thread overview]
Message-ID: <CAGyQ6gyc75jNBa-gS+TNo_3OXBwJ=Z89R1GrNxs1O=jykZfoNA@mail.gmail.com> (raw)
In-Reply-To: <201411041458.sA4EwuJT001432@d06av02.portsmouth.uk.ibm.com>
On Tue, Nov 4, 2014 at 6:58 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> Siva Chandra wrote:
>> On Tue, Nov 4, 2014 at 5:38 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
>> > Yes, having an additional flag in struct expression would fix the safety
>> > issue. Moving initialization to evalute_subexp if *pos == 0 would then
>> > no longer be safety issue, but simply enabling use of temporaries in more
>> > cases.
>>
>> Since I have my code already setup in this fashion, I would prefer to
>> go this route unless you see an advantage of going with the solution
>> you suggest below.
>
> Well, I don't think there are any functional advantages as such, but the
> implementation looks a bit cleaner (all the details of temporary handling
> done in infcall.c; fewer interactions between eval.c and infcall.c;
> shorter patch overall).
Shall I go with the thread route then?
next prev parent reply other threads:[~2014-11-04 15:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 14:24 Siva Chandra
2014-11-03 14:35 ` Siva Chandra
2014-11-03 14:43 ` Ulrich Weigand
2014-11-03 19:55 ` Siva Chandra
2014-11-03 21:22 ` Siva Chandra
2014-11-04 13:43 ` Ulrich Weigand
2014-11-04 15:08 ` Siva Chandra
2014-11-04 15:40 ` Ulrich Weigand
2014-11-04 13:38 ` Ulrich Weigand
2014-11-04 14:26 ` Siva Chandra
2014-11-04 14:59 ` Ulrich Weigand
2014-11-04 15:23 ` Siva Chandra [this message]
2014-11-04 15:40 ` Ulrich Weigand
2014-11-11 14:55 ` Siva Chandra
2014-11-11 15:00 ` Siva Chandra
2014-11-11 15:21 ` Ulrich Weigand
2014-11-11 17:05 ` Siva Chandra
2014-11-12 16:08 ` Doug Evans
2014-11-12 17:29 ` Doug Evans
2014-11-13 3:00 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gyc75jNBa-gS+TNo_3OXBwJ=Z89R1GrNxs1O=jykZfoNA@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox